cybercyst/ghostty
1
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-05-05 15:33:00 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

terminal(dcs): convert all xtgettcap queries to upper

Browse Source 
XTGETTCAP queries are a semicolon-delimited list of hex encoded terminfo
capability names. Ghostty encodes a map using upper case hex encodings,
meaning when an application uses a lower case encoding the capability is
not found. To fix, we convert the entire list we receive in the query to
upper case prior to processing further.

Fixes: #7229
This commit is contained in:
Tim Culverhouse 2025-04-29 18:42:16 -05:00
parent 533354480a
commit 2c1ade763f
No known key found for this signature in database
1 changed files with 22 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/terminal/dcs.zig
View File

@ -162,7 +162,12 @@ pub const Handler = struct {
break :tmux .{ .tmux = .{ .exit = {} } };
},
.xtgettcap => |list| .{ .xtgettcap = .{ .data = list } },
.xtgettcap => |list| xtgettcap: {
for (list.items, 0..) |b, i| {
list.items[i] = std.ascii.toUpper(b);
}
break :xtgettcap .{ .xtgettcap = .{ .data = list } };
},
.decrqss => |buffer| .{ .decrqss = switch (buffer.len) {
0 => .none,
@ -306,6 +311,21 @@ test "XTGETTCAP command" {
try testing.expect(cmd.xtgettcap.next() == null);
}
test "XTGETTCAP mixed case" {
const testing = std.testing;
const alloc = testing.allocator;
var h: Handler = .{};
defer h.deinit();
try testing.expect(h.hook(alloc, .{ .intermediates = "+", .final = 'q' }) == null);
for ("536d756C78") |byte| _ = h.put(byte);
var cmd = h.unhook().?;
defer cmd.deinit();
try testing.expect(cmd == .xtgettcap);
try testing.expectEqualStrings("536D756C78", cmd.xtgettcap.next().?);
try testing.expect(cmd.xtgettcap.next() == null);
}
test "XTGETTCAP command multiple keys" {
const testing = std.testing;
const alloc = testing.allocator;
@ -333,7 +353,7 @@ test "XTGETTCAP command invalid data" {
var cmd = h.unhook().?;
defer cmd.deinit();
try testing.expect(cmd == .xtgettcap);
try testing.expectEqualStrings("who", cmd.xtgettcap.next().?);
try testing.expectEqualStrings("WHO", cmd.xtgettcap.next().?);
try testing.expectEqualStrings("536D756C78", cmd.xtgettcap.next().?);
try testing.expect(cmd.xtgettcap.next() == null);
}