From 1118e321773317cd9c33899ba792f49df8ec25d5 Mon Sep 17 00:00:00 2001 From: Rebecca Stambler Date: Fri, 1 Nov 2019 16:50:24 -0400 Subject: [PATCH] internal/lsp: fix nil pointer in textDocument/didClose Fixes golang/go#35165 Change-Id: I1a4cb2bae89c2eeb52908c622ce17913f3c2a3c5 Reviewed-on: https://go-review.googlesource.com/c/tools/+/204823 Run-TryBot: Rebecca Stambler Reviewed-by: Michael Matloob TryBot-Result: Gobot Gobot --- internal/lsp/text_synchronization.go | 1 + 1 file changed, 1 insertion(+) diff --git a/internal/lsp/text_synchronization.go b/internal/lsp/text_synchronization.go index 303f66f41f..4019daca12 100644 --- a/internal/lsp/text_synchronization.go +++ b/internal/lsp/text_synchronization.go @@ -155,6 +155,7 @@ func (s *Server) didClose(ctx context.Context, params *protocol.DidCloseTextDocu f, err := view.GetFile(ctx, uri) if err != nil { log.Error(ctx, "no file", err, telemetry.URI) + return nil } _, cphs, err := view.CheckPackageHandles(ctx, f) if err != nil {