cybercyst/go
1
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-05-19 06:14:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Revert "cmd/go: add telemetry counters for flag names and subcommand"

Browse Source 
This reverts CL 559519.

Reason for revert: Broke windows/386. See https://build.golang.org/log/03594b706c425bd61fb3c65495aae6dd01b4a81b.

Fixes #65447.

Change-Id: I567bca0368168dbfb256fadba37bce3cd31aceb2
Reviewed-on: https://go-review.googlesource.com/c/go/+/560655
Reviewed-by: Bryan Mills <bcmills@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
This commit is contained in:
Quim Muntal 2024-02-02 13:30:55 +00:00
parent 117164f9e3
commit 244ccf4769
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/cmd/go/main.go
View File

@ -97,7 +97,6 @@ func main() {
flag.Usage = base.Usage flag.Usage = base.Usage
flag.Parse() flag.Parse()
counter.CountFlags("cmd/go:flag-", *flag.CommandLine)
args := flag.Args() args := flag.Args()
if len(args) < 1 { if len(args) < 1 {
@ -153,7 +152,6 @@ func main() {
cmd, used := lookupCmd(args) cmd, used := lookupCmd(args)
cfg.CmdName = strings.Join(args[:used], " ") cfg.CmdName = strings.Join(args[:used], " ")
counter.Inc("cmd/go:subcommand-" + strings.ReplaceAll(cfg.CmdName, " ", "-"))
if len(cmd.Commands) > 0 { if len(cmd.Commands) > 0 {
if used >= len(args) { if used >= len(args) {
help.PrintUsage(os.Stderr, cmd) help.PrintUsage(os.Stderr, cmd)
@ -241,7 +239,6 @@ func invoke(cmd *base.Command, args []string) {
} else { } else {
base.SetFromGOFLAGS(&cmd.Flag) base.SetFromGOFLAGS(&cmd.Flag)
cmd.Flag.Parse(args[1:]) cmd.Flag.Parse(args[1:])
counter.CountFlags("cmd/go/"+cmd.Name()+":flag-", cmd.Flag)
args = cmd.Flag.Args() args = cmd.Flag.Args()
} }
@ -326,7 +323,6 @@ func handleChdirFlag() {
_, dir, _ = strings.Cut(a, "=") _, dir, _ = strings.Cut(a, "=")
os.Args = slices.Delete(os.Args, used, used+1) os.Args = slices.Delete(os.Args, used, used+1)
} }
counter.Inc("cmd/go:flag-C")
if err := os.Chdir(dir); err != nil { if err := os.Chdir(dir); err != nil {
base.Fatalf("go: %v", err) base.Fatalf("go: %v", err)