cybercyst/go
1
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-05-05 23:53:05 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Revert "cmd/compile: add missing OINLCAll case in mayModifyPkgVar"

Browse Source 
This reverts CL 575175.

Reason for revert: causes crypto/ecdh failures on longtest builders.

Change-Id: Ieed326fedf91760ac73095a42ba0237cf969843b
Reviewed-on: https://go-review.googlesource.com/c/go/+/575316
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Than McIntosh <thanm@google.com>
Reviewed-by: David Chase <drchase@google.com>
Auto-Submit: Than McIntosh <thanm@google.com>
This commit is contained in:
Than McIntosh 2024-03-29 21:31:56 +00:00 committed by Gopher Robot
parent 9a028e14a5
commit 29fcd1569a
2 changed files with 0 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/cmd/compile/internal/staticinit/sched.go
View File

@ -890,9 +890,6 @@ func mayModifyPkgVar(n ir.Node) bool {
case ir.OCALLFUNC, ir.OCALLINTER: case ir.OCALLFUNC, ir.OCALLINTER:
return !ir.IsFuncPCIntrinsic(n.(*ir.CallExpr)) return !ir.IsFuncPCIntrinsic(n.(*ir.CallExpr))
case ir.OINLCALL:
return true
case ir.OAPPEND, ir.OCLEAR, ir.OCOPY: case ir.OAPPEND, ir.OCLEAR, ir.OCOPY:
return true // could mutate a global array return true // could mutate a global array

25
test/fixedbugs/issue66585.go
View File

@ -1,25 +0,0 @@
// run
// Copyright 2024 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
package main
var x = 0
var a = foo()
var b = x
func foo() int {
x++
return x
}
func main() {
if a != 1 {
panic("unexpected a value")
}
if b != 1 {
panic("unexpected b value")
}
}