cybercyst/go
1
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-05-29 11:25:43 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

cmd/vet: honor analyzer flags when running vet outside $GOROOT/src

Browse Source 
Additional vet flags specified by user are discarded if 'go vet'
is invoked outside $GOROOT/src to check a package under $GOROOT
(including those under "vendor" of $GOROOT), fix it by avoiding the
overwriting, the logic of detemining if the package under vetting
comes from $GOROOT remains untouched.

Also checked 'go tool vet <options> <cfg>' and 'go vet <options>
<user pkg>', both worked w./w.o this fix.

Fixes #35837.

Change-Id: I549af7964e40440afd35f2d1971f77eee6f8de34
Reviewed-on: https://go-review.googlesource.com/c/go/+/209498
Run-TryBot: Jay Conrod <jayconrod@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
This commit is contained in:
Xiangdong Ji 2019-11-22 17:02:06 +00:00 committed by Jay Conrod
parent 386b1a4280
commit 2ac1ca9160
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/cmd/go/internal/work/exec.go
View File

@ -1036,7 +1036,7 @@ func (b *Builder) vet(a *Action) error {
// There's too much unsafe.Pointer code // There's too much unsafe.Pointer code
// that vet doesn't like in low-level packages // that vet doesn't like in low-level packages
// like runtime, sync, and reflect. // like runtime, sync, and reflect.
vetFlags = []string{"-unsafeptr=false"} vetFlags = append(vetFlags, string("-unsafeptr=false"))
} }
// Note: We could decide that vet should compute export data for // Note: We could decide that vet should compute export data for

8
src/cmd/go/testdata/script/vet_flags.txt vendored Normal file
View File

@ -0,0 +1,8 @@
env GO111MODULE=off
# Issue 35837. Verify that "go vet -<analyzer> <std package>" works if 'pwd' is not $GOROOT/src
# we utilize the package runtime/testdata/testprog as the issue is specific to vetting standard package
go vet -n -unreachable=false runtime/testdata/testprog
stderr '-unreachable=false'
stderr '-unsafeptr=false'