cybercyst/go
1
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-05-18 22:04:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

runtime: initialize crashFD to -1

Browse Source 
crashFD defaults to the zero value of (surprise!) zero. Zero is a valid
FD, so on the first call to SetCrashOutput we actually close FD 0 since
it is a "valid" FD.

Initialize crashFD to -1, the sentinel for "no FD".

Change-Id: I3b108c60603f2b83b867cbe079f035c159b6a6ca
Reviewed-on: https://go-review.googlesource.com/c/go/+/560776
Reviewed-by: Alan Donovan <adonovan@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This commit is contained in:
Michael Pratt 2024-02-02 13:00:02 -05:00
parent 6b0309ceb6
commit 3d20a327a1
2 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/runtime/proc.go
View File

@ -775,6 +775,7 @@ func schedinit() {
} }
sched.maxmcount = 10000 sched.maxmcount = 10000
crashFD.Store(^uintptr(0))
// The world starts stopped. // The world starts stopped.
worldStopped() worldStopped()

2
src/runtime/runtime.go
View File

@ -244,6 +244,8 @@ func writeErrData(data *byte, n int32) {
// set by debug.SetCrashOutput (see #42888). If it is a valid fd (not // set by debug.SetCrashOutput (see #42888). If it is a valid fd (not
// all ones), writeErr and related functions write to it in addition // all ones), writeErr and related functions write to it in addition
// to standard error. // to standard error.
//
// Initialized to -1 in schedinit.
var crashFD atomic.Uintptr var crashFD atomic.Uintptr
//go:linkname setCrashFD //go:linkname setCrashFD