cybercyst/go
1
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-05-29 11:25:43 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

cmd/compile: update TestStmtLines threshold for riscv64

Browse Source 
CL402374 default regabi for riscv64 but TestStmtLines
keep fail trybot within a tiny overlimit (2.006% > 2%).
This CL update this threshold to 3% for riscv64 as an
acceptable temporary solution.

Change-Id: I5c6f37099a76bc048998eb95f49944dbe55492f4
Reviewed-on: https://go-review.googlesource.com/c/go/+/404195
Run-TryBot: mzh <mzh@golangcn.org>
Reviewed-by: David Chase <drchase@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
This commit is contained in:
Meng Zhuo 2022-05-05 12:08:42 +08:00 committed by mzh
parent 7dd9884562
commit 3ea3bc0e96
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/cmd/compile/internal/ssa/stmtlines_test.go
View File

@ -118,12 +118,17 @@ func TestStmtLines(t *testing.T) {
} }
} }
var m int
if runtime.GOARCH == "amd64" { if runtime.GOARCH == "amd64" {
if len(nonStmtLines)*100 > len(lines) { // > 99% obtained on amd64, no backsliding m = 1 // > 99% obtained on amd64, no backsliding
t.Errorf("Saw too many (amd64, > 1%%) lines without statement marks, total=%d, nostmt=%d ('-run TestStmtLines -v' lists failing lines)\n", len(lines), len(nonStmtLines)) } else if runtime.GOARCH == "riscv64" {
} m = 3 // XXX temporary update threshold to 97% for regabi
} else if len(nonStmtLines)*100 > 2*len(lines) { // expect 98% elsewhere. } else {
t.Errorf("Saw too many (not amd64, > 2%%) lines without statement marks, total=%d, nostmt=%d ('-run TestStmtLines -v' lists failing lines)\n", len(lines), len(nonStmtLines)) m = 2 // expect 98% elsewhere.
}
if len(nonStmtLines)*100 > m*len(lines) {
t.Errorf("Saw too many (%s, > %d%%) lines without statement marks, total=%d, nostmt=%d ('-run TestStmtLines -v' lists failing lines)\n", runtime.GOARCH, m, len(lines), len(nonStmtLines))
} }
t.Logf("Saw %d out of %d lines without statement marks", len(nonStmtLines), len(lines)) t.Logf("Saw %d out of %d lines without statement marks", len(nonStmtLines), len(lines))
if testing.Verbose() { if testing.Verbose() {