diff --git a/src/net/http/httptest/recorder.go b/src/net/http/httptest/recorder.go index 1d0310625b..67f90b8376 100644 --- a/src/net/http/httptest/recorder.go +++ b/src/net/http/httptest/recorder.go @@ -184,6 +184,8 @@ func (rw *ResponseRecorder) Result() *http.Response { res.Status = fmt.Sprintf("%03d %s", res.StatusCode, http.StatusText(res.StatusCode)) if rw.Body != nil { res.Body = ioutil.NopCloser(bytes.NewReader(rw.Body.Bytes())) + } else { + res.Body = http.NoBody } res.ContentLength = parseContentLength(res.Header.Get("Content-Length")) diff --git a/src/net/http/httptest/recorder_test.go b/src/net/http/httptest/recorder_test.go index b5f82d23e6..0986554aa8 100644 --- a/src/net/http/httptest/recorder_test.go +++ b/src/net/http/httptest/recorder_test.go @@ -7,6 +7,7 @@ package httptest import ( "fmt" "io" + "io/ioutil" "net/http" "testing" ) @@ -39,6 +40,19 @@ func TestRecorder(t *testing.T) { return nil } } + hasResultContents := func(want string) checkFunc { + return func(rec *ResponseRecorder) error { + contentBytes, err := ioutil.ReadAll(rec.Result().Body) + if err != nil { + return err + } + contents := string(contentBytes) + if contents != want { + return fmt.Errorf("Result().Body = %s; want %s", contents, want) + } + return nil + } + } hasContents := func(want string) checkFunc { return func(rec *ResponseRecorder) error { if rec.Body.String() != want { @@ -273,6 +287,15 @@ func TestRecorder(t *testing.T) { }, check(hasStatus(200), hasContents("Some body"), hasContentLength(9)), }, + { + "nil ResponseRecorder.Body", // Issue 26642 + func(w http.ResponseWriter, r *http.Request) { + w.(*ResponseRecorder).Body = nil + io.WriteString(w, "hi") + }, + check(hasResultContents("")), // check we don't crash reading the body + + }, } { t.Run(tt.name, func(t *testing.T) { r, _ := http.NewRequest("GET", "http://foo.com/", nil)