From 64da2da6fb1d10fca4e8a36fe52f4beeed487279 Mon Sep 17 00:00:00 2001 From: Ian Cottrell Date: Mon, 4 Nov 2019 17:59:33 -0500 Subject: [PATCH] internal/lsp: fix the debug info pages There was a dealock introduced in cl/190737 on all the internal structure debug pages. The object getters all protect with the mutex already, it should not also be done in the outer Render function Change-Id: I5c85dc8e2ec489e59ca5a80128f2649dd7753983 Reviewed-on: https://go-review.googlesource.com/c/tools/+/205165 Run-TryBot: Ian Cottrell Reviewed-by: Rebecca Stambler TryBot-Result: Gobot Gobot --- internal/lsp/debug/serve.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/lsp/debug/serve.go b/internal/lsp/debug/serve.go index 0a935274f6..c62a5256ce 100644 --- a/internal/lsp/debug/serve.go +++ b/internal/lsp/debug/serve.go @@ -248,8 +248,6 @@ func Serve(ctx context.Context, addr string) error { func Render(tmpl *template.Template, fun func(*http.Request) interface{}) func(http.ResponseWriter, *http.Request) { return func(w http.ResponseWriter, r *http.Request) { - mu.Lock() - defer mu.Unlock() var data interface{} if fun != nil { data = fun(r)