cybercyst/go
1
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-05-28 10:51:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

syscall: make TestGetdirentries checkptr safe

Browse Source 
Fixes Darwin.

Updates #35092

Change-Id: I045f070c8549d00610b459e3a82cac870d9ddb54
Reviewed-on: https://go-review.googlesource.com/c/go/+/203077
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
This commit is contained in:
Brad Fitzpatrick 2019-10-23 20:54:05 -07:00
parent a52c0a1992
commit 68981bf309
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/syscall/getdirentries_test.go
View File

@ -66,7 +66,15 @@ func testGetdirentries(t *testing.T, count int) {
}
data := buf[:n]
for len(data) > 0 {
dirent := (*syscall.Dirent)(unsafe.Pointer(&data[0]))
// syscall.Getdirentries's return value may be (and usually is) much
// smaller than a syscall.Dirent, which has lots of padding for
// the name at the end. The compiler's checkptr validation doesn't like
// that. So allocate direntMem that's always big enough, and use that
// when converting to *syscall.Dirent.
var direntMem [unsafe.Sizeof(syscall.Dirent{})]byte
copy(direntMem[:], data)
dirent := (*syscall.Dirent)(unsafe.Pointer(&direntMem[0]))
data = data[dirent.Reclen:]
name := make([]byte, dirent.Namlen)
for i := 0; i < int(dirent.Namlen); i++ {