cybercyst/go
1
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-05-18 13:54:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

cmd/compile: rename (*Type).HasPointer to (*Type).HasHeapPointer

Browse Source 
This method indicates whether a type contains any *heap* pointers, not
just whether it contains any pointers. Rename the method to make this
clear.

Change-Id: Ifff143e2f02a820444ac26b84250495c0098cb33
Reviewed-on: https://go-review.googlesource.com/67690
Run-TryBot: Austin Clements <austin@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
This commit is contained in:
Austin Clements 2017-10-02 17:31:43 -04:00
parent f47c8f130e
commit 70258cc59f
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/cmd/compile/internal/ssa/writebarrier.go
View File

@ -17,7 +17,7 @@ func needwb(v *Value) bool {
if !ok { if !ok {
v.Fatalf("store aux is not a type: %s", v.LongString()) v.Fatalf("store aux is not a type: %s", v.LongString())
} }
if !t.HasPointer() { if !t.HasHeapPointer() {
return false return false
} }
if IsStackAddr(v.Args[0]) { if IsStackAddr(v.Args[0]) {

4
src/cmd/compile/internal/types/type.go
View File

@ -1391,10 +1391,10 @@ func Haspointers(t *Type) bool {
return true return true
} }
// HasPointer returns whether t contains heap pointer. // HasHeapPointer returns whether t contains a heap pointer.
// This is used for write barrier insertion, so we ignore // This is used for write barrier insertion, so we ignore
// pointers to go:notinheap types. // pointers to go:notinheap types.
func (t *Type) HasPointer() bool { func (t *Type) HasHeapPointer() bool {
if t.IsPtr() && t.Elem().NotInHeap() { if t.IsPtr() && t.Elem().NotInHeap() {
return false return false
} }