cybercyst/go
1
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-05-05 15:43:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

runtime: don't restore from g0.sched in systemstack on arm64

Browse Source 
On arm64, systemstack restores the frame pointer from g0.sched to R29
prior to calling the callback. That doesn't really make any sense. The
frame pointer value in g0.sched is some arbitrary BP from a prior
context save, but that is not the caller of systemstack.

amd64 does not do this. In fact, it leaves BP completely unmodified so
frame pointer unwinders like gdb can walk through the systemstack frame
and continue traceback on the caller's stack. Unlike mcall, systemstack
always returns to the original goroutine, so that is safe.

We should do the same on arm64.

For #63630.

Cq-Include-Trybots: luci.golang.try:gotip-linux-arm64-longtest
Change-Id: I6a6a636c35d321dd5d7dc1c4d09e29b55b1ab621
Reviewed-on: https://go-review.googlesource.com/c/go/+/669236
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Auto-Submit: Michael Pratt <mpratt@google.com>
Reviewed-by: Nick Ripley <nick.ripley@datadoghq.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This commit is contained in:
Michael Pratt 2025-04-30 15:14:50 -04:00 committed by Gopher Robot
parent 9c1d19a183
commit 739fb752e3
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/runtime/asm_arm64.s
View File

@ -276,7 +276,10 @@ TEXT runtime·systemstack(SB), NOSPLIT, $0-8
B runtime·abort(SB) B runtime·abort(SB)
switch: switch:
// save our state in g->sched. Pretend to // Switch stacks.
// The original frame pointer is stored in R29,
// which is useful for stack unwinding.
// Save our state in g->sched. Pretend to
// be systemstack_switch if the G stack is scanned. // be systemstack_switch if the G stack is scanned.
BL gosave_systemstack_switch<>(SB) BL gosave_systemstack_switch<>(SB)
@ -285,7 +288,6 @@ switch:
BL runtime·save_g(SB) BL runtime·save_g(SB)
MOVD (g_sched+gobuf_sp)(g), R3 MOVD (g_sched+gobuf_sp)(g), R3
MOVD R3, RSP MOVD R3, RSP
MOVD (g_sched+gobuf_bp)(g), R29
// call target function // call target function
MOVD 0(R26), R3 // code pointer MOVD 0(R26), R3 // code pointer