From 744fcfec4e94d9585d2be6f9efae8480a2f2fc8d Mon Sep 17 00:00:00 2001 From: Austin Clements Date: Fri, 19 Apr 2019 15:56:37 -0400 Subject: [PATCH] runtime: improve mstart comments Some of the comments were unclear or outdated. Change-Id: I02e01bf60def0074c1fa760e94aa992e9e4969b9 Reviewed-on: https://go-review.googlesource.com/c/go/+/172987 Run-TryBot: Austin Clements TryBot-Result: Gobot Gobot Reviewed-by: Michael Knyszek --- src/runtime/proc.go | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/runtime/proc.go b/src/runtime/proc.go index 30ddeadff5..57ad17d594 100644 --- a/src/runtime/proc.go +++ b/src/runtime/proc.go @@ -1125,7 +1125,7 @@ func startTheWorldWithSema(emitTraceEvent bool) int64 { return startTime } -// Called to start an M. +// mstart is the entry-point for new Ms. // // This must not split the stack because we may not even have stack // bounds set up yet. @@ -1150,9 +1150,11 @@ func mstart() { _g_.stack.hi = uintptr(noescape(unsafe.Pointer(&size))) _g_.stack.lo = _g_.stack.hi - size + 1024 } - // Initialize stack guards so that we can start calling - // both Go and C functions with stack growth prologues. + // Initialize stack guard so that we can start calling regular + // Go code. _g_.stackguard0 = _g_.stack.lo + _StackGuard + // This is the g0, so we can also call go:systemstack + // functions, which check stackguard1. _g_.stackguard1 = _g_.stackguard0 mstart1()