cybercyst/go
1
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-05-06 08:03:03 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

misc/ios: retry app install

Browse Source 
Sometimes ideviceinstaller fails to install the app. Retry a few
times before giving up.

For the iOS builder.

Change-Id: Ib066ffd4f97ae8d22c0fa9a78ea4d04f67c17410
Reviewed-on: https://go-review.googlesource.com/111055
Run-TryBot: Elias Naur <elias.naur@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This commit is contained in:
Elias Naur 2018-05-02 23:26:58 +02:00
parent 7b451dc715
commit 78cb5d7a68
1 changed files with 18 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
misc/ios/go_darwin_arm_exec.go
View File

@ -377,16 +377,26 @@ func findDeviceAppPath(bundleID string) (string, error) {
} }
func install(appdir string) error { func install(appdir string) error {
attempt := 0
for {
cmd := idevCmd(exec.Command( cmd := idevCmd(exec.Command(
"ideviceinstaller", "ideviceinstaller",
"-i", appdir, "-i", appdir,
)) ))
if out, err := cmd.CombinedOutput(); err != nil { if out, err := cmd.CombinedOutput(); err != nil {
// Sometimes, installing the app fails for some reason.
// Give the device a few seconds and try again.
if attempt < 5 {
time.Sleep(5 * time.Second)
attempt++
continue
}
os.Stderr.Write(out) os.Stderr.Write(out)
return fmt.Errorf("ideviceinstaller -i %q: %v", appdir, err) return fmt.Errorf("ideviceinstaller -i %q: %v (%d attempts)", appdir, err, attempt)
} }
return nil return nil
} }
}
func idevCmd(cmd *exec.Cmd) *exec.Cmd { func idevCmd(cmd *exec.Cmd) *exec.Cmd {
if deviceID != "" { if deviceID != "" {