From 7b6f5d95f3a9ab10286a3a4fdde2b87781f40992 Mon Sep 17 00:00:00 2001 From: Brad Fitzpatrick Date: Thu, 24 Oct 2019 04:25:51 +0000 Subject: [PATCH] internal/memoize: add a go:nocheckptr annotation to (*Store).get Fixes golang/go#35125 Change-Id: I08251b94a44fbc2324f6edc883d9d687b45a00b0 Reviewed-on: https://go-review.googlesource.com/c/tools/+/203078 Run-TryBot: Brad Fitzpatrick TryBot-Result: Gobot Gobot Reviewed-by: Matthew Dempsky --- internal/memoize/memoize.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/internal/memoize/memoize.go b/internal/memoize/memoize.go index 12e61e8799..da3e365b34 100644 --- a/internal/memoize/memoize.go +++ b/internal/memoize/memoize.go @@ -121,6 +121,8 @@ func (s *Store) Cached(key interface{}) interface{} { return h.Cached() } +//go:nocheckptr +// nocheckptr because: https://github.com/golang/go/issues/35125#issuecomment-545671062 func (s *Store) get(key interface{}) *Handle { // this must be called with the store mutex already held e, found := s.entries[key]