cybercyst/go
1
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-05-23 08:21:24 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

net/http: fix a long test after CL 185117

Browse Source 
The net/url error in question now quotes the URL, so update the expected
output string.

While at it, also update a comment in httputil, though that doesn't
affect any test.

Fixes #33910.

Change-Id: I0981f528b24337c2952ef60c0db3b7ff72d72110
Reviewed-on: https://go-review.googlesource.com/c/go/+/192078
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
This commit is contained in:
Daniel Martí 2019-08-28 15:50:31 +02:00
parent 372b0eed17
commit 81fde0c941
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/net/http/httputil/reverseproxy_test.go
View File

@ -436,7 +436,7 @@ func TestReverseProxyCancelation(t *testing.T) {
} }
if err == nil { if err == nil {
// This should be an error like: // This should be an error like:
// Get http://127.0.0.1:58079: read tcp 127.0.0.1:58079: // Get "http://127.0.0.1:58079": read tcp 127.0.0.1:58079:
// use of closed network connection // use of closed network connection
t.Error("Server.Client().Do() returned nil error; want non-nil error") t.Error("Server.Client().Do() returned nil error; want non-nil error")
} }

2
src/net/http/transport_test.go
View File

@ -2289,7 +2289,7 @@ func TestTransportCancelRequestInDial(t *testing.T) {
got := logbuf.String() got := logbuf.String()
want := `dial: blocking want := `dial: blocking
canceling canceling
Get = Get http://something.no-network.tld/: net/http: request canceled while waiting for connection Get = Get "http://something.no-network.tld/": net/http: request canceled while waiting for connection
` `
if got != want { if got != want {
t.Errorf("Got events:\n%s\nWant:\n%s", got, want) t.Errorf("Got events:\n%s\nWant:\n%s", got, want)