From 839b28246f7ec04b6d5a8d747a84d6c8bb1c33ef Mon Sep 17 00:00:00 2001 From: Kevin Burke Date: Thu, 17 Aug 2017 08:16:57 -0700 Subject: [PATCH] time: add leap year test for Date I'm writing a matching implementation of the time package and missed the "add one day in a leap year" block. This test would have caught my error. I understand we can't add test cases for every Date but it seems like "tripped up someone attempting to reimplement this" is a good indicator it may trip up people in the future. Change-Id: I4c3b51e52e269215ec0e52199afe604482326edb Reviewed-on: https://go-review.googlesource.com/56490 Reviewed-by: Matt Layher Reviewed-by: Ian Lance Taylor Run-TryBot: Matt Layher TryBot-Result: Gobot Gobot --- src/time/time_test.go | 1 + 1 file changed, 1 insertion(+) diff --git a/src/time/time_test.go b/src/time/time_test.go index dba8e0dadc..00ced4ba9b 100644 --- a/src/time/time_test.go +++ b/src/time/time_test.go @@ -575,6 +575,7 @@ var dateTests = []struct { {2011, 3, 13, 1, 59, 59, 0, Local, 1300010399}, // 1:59:59 PST {2011, 3, 13, 3, 0, 0, 0, Local, 1300010400}, // 3:00:00 PDT {2011, 3, 13, 2, 30, 0, 0, Local, 1300008600}, // 2:30:00 PDT ≡ 1:30 PST + {2012, 12, 24, 0, 0, 0, 0, Local, 1356336000}, // Leap year // Many names for Fri Nov 18 7:56:35 PST 2011 {2011, 11, 18, 7, 56, 35, 0, Local, 1321631795}, // Nov 18 7:56:35