From 843fec1c7d75cac3f76620e79f1680d8f058c501 Mon Sep 17 00:00:00 2001 From: Julien Schmidt Date: Mon, 30 Sep 2019 00:07:34 +0000 Subject: [PATCH] database/sql: preallocate list slice in Drivers() The required slice capacity is already known. Thus, preallocate a slice with the correct capacity before appending to it. Change-Id: I45ac2c5f1701caeb3dda20451d371713ae7e7365 GitHub-Last-Rev: 2bf575be65e9a449322540270988eaf87cec4245 GitHub-Pull-Request: golang/go#34602 Reviewed-on: https://go-review.googlesource.com/c/go/+/197917 Reviewed-by: Brad Fitzpatrick Run-TryBot: Brad Fitzpatrick TryBot-Result: Gobot Gobot --- src/database/sql/sql.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/database/sql/sql.go b/src/database/sql/sql.go index 93001635be..0f5bbc01c9 100644 --- a/src/database/sql/sql.go +++ b/src/database/sql/sql.go @@ -64,7 +64,7 @@ func unregisterAllDrivers() { func Drivers() []string { driversMu.RLock() defer driversMu.RUnlock() - var list []string + list := make([]string, 0, len(drivers)) for name := range drivers { list = append(list, name) }