cybercyst/go
1
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-05-05 15:43:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Revert "go/packages: temporarily disable some tests running on go tip with -race"

Browse Source 
This reverts CL 200819.

Reason for revert: known races in dependencies have been fixed.

Change-Id: I7019055ea57b846d7546fbcc628fb341b7351a99
Reviewed-on: https://go-review.googlesource.com/c/tools/+/202538
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
This commit is contained in:
Bryan C. Mills 2019-10-21 18:43:00 +00:00
parent b2104f82a9
commit 8715e36070
7 changed files with 0 additions and 68 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
go/analysis/multichecker/multichecker_race_test.go
View File

@ -1,15 +0,0 @@
// Copyright 2019 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
//+build race
// This file exists to allow us to detect that we're in race detector mode for temporarily
// disabling tests that are broken on tip with the race detector turned on.
// TODO(matloob): delete this once golang.org/issue/31749 is fixed.
package multichecker_test
func init() {
race = true
}

7
go/analysis/multichecker/multichecker_test.go
View File

@ -7,7 +7,6 @@ import (
"os"
"os/exec"
"runtime"
"strings"
"testing"
"golang.org/x/tools/go/analysis"
@ -30,15 +29,9 @@ func main() {
multichecker.Main(findcall.Analyzer, fail)
}
var race = false
// TestExitCode ensures that analysis failures are reported correctly.
// This test fork/execs the main function above.
func TestExitCode(t *testing.T) {
if v := runtime.Version(); strings.Contains(v, "devel") && race {
t.Skip("golang.org/issue/31749: This test is broken on tip in race mode. Skip until it's fixed.")
}
if runtime.GOOS != "linux" {
t.Skipf("skipping fork/exec test on this platform")
}

15
go/loader/loader_race_test.go
View File

@ -1,15 +0,0 @@
// Copyright 2019 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
//+build race
// This file exists to allow us to detect that we're in race detector mode for temporarily
// disabling tests that are broken on tip with the race detector turned on.
// TODO(matloob): delete this once golang.org/issue/31749 is fixed.
package loader_test
func init() {
race = true
}

6
go/loader/loader_test.go
View File

@ -262,13 +262,7 @@ func TestLoad_FromSource_Success(t *testing.T) {
}
}
var race = false
func TestLoad_FromImports_Success(t *testing.T) {
if v := runtime.Version(); strings.Contains(v, "devel") && race {
t.Skip("golang.org/issue/31749: This test is broken on tip in race mode. Skip until it's fixed.")
}
if runtime.Compiler == "gccgo" {
t.Skip("gccgo has no standard library test files")
}

15
go/packages/packages_race_test.go
View File

@ -1,15 +0,0 @@
// Copyright 2019 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
//+build race
// This file exists to allow us to detect that we're in race detector mode for temporarily
// disabling tests that are broken on tip with the race detector turned on.
// TODO(matloob): delete this once golang.org/issue/31749 is fixed.
package packages_test
func init() {
race = true
}

6
go/packages/packages_test.go
View File

@ -2342,14 +2342,8 @@ const A = 4
}
}
var race = false
func TestIssue32814(t *testing.T) { packagestest.TestAll(t, testIssue32814) }
func testIssue32814(t *testing.T, exporter packagestest.Exporter) {
if v := runtime.Version(); strings.Contains(v, "devel") && race {
t.Skip("golang.org/issue/31749: This test is broken on tip in race mode. Skip until it's fixed.")
}
exported := packagestest.Export(t, exporter, []packagestest.Module{{
Name: "golang.org/fake",
Files: map[string]interface{}{}}})

4
go/packages/stdlib_test.go
View File

@ -19,10 +19,6 @@ import (
// This test loads the metadata for the standard library,
func TestStdlibMetadata(t *testing.T) {
if v := runtime.Version(); strings.Contains(v, "devel") && race {
t.Skip("golang.org/issue/31749: This test is broken on tip in race mode. Skip until it's fixed.")
}
// TODO(adonovan): see if we can get away without this hack.
// if runtime.GOOS == "android" {
// t.Skipf("incomplete std lib on %s", runtime.GOOS)