From 88a1e85c706a7917f97be9c612334f0c85e96cf3 Mon Sep 17 00:00:00 2001 From: Hiroshi Ioka Date: Sun, 27 Aug 2017 19:09:18 +0900 Subject: [PATCH] cmd/link: fix warning for buildmode=plugin on darwin/amd64 Without this CL, the system linker complains about absolute addressing in type..eqfunc.*. Updates #18190 Change-Id: I68db37a7f4c96b16a9c13baffc0f043a3048df6d Reviewed-on: https://go-review.googlesource.com/59373 Reviewed-by: Ian Lance Taylor Run-TryBot: Ian Lance Taylor TryBot-Result: Gobot Gobot --- src/cmd/link/internal/ld/lib.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/cmd/link/internal/ld/lib.go b/src/cmd/link/internal/ld/lib.go index efa0a275e0..1977ea5173 100644 --- a/src/cmd/link/internal/ld/lib.go +++ b/src/cmd/link/internal/ld/lib.go @@ -1096,7 +1096,8 @@ func (l *Link) hostlink() { argv = append(argv, "-Wl,-headerpad,1144") if l.DynlinkingGo() { argv = append(argv, "-Wl,-flat_namespace") - } else if !SysArch.InFamily(sys.ARM64) && Buildmode != BuildmodePIE { + } + if Buildmode == BuildmodeExe && !SysArch.InFamily(sys.ARM64) { argv = append(argv, "-Wl,-no_pie") } case objabi.Hopenbsd: