mirror of
https://github.com/golang/go.git
synced 2025-05-05 23:53:05 +00:00
cmd/compile: fix ir.StaticValue for ORANGE
Range statement will mutate the key and value, so we should treat them as reassigned. Fixes #59572 Change-Id: I9c6b67d938760a0c6a1d9739f2737c67af4a3a10 Reviewed-on: https://go-review.googlesource.com/c/go/+/483855 Run-TryBot: Wayne Zuo <wdvxdr@golangcn.org> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Matthew Dempsky <mdempsky@google.com> Auto-Submit: Keith Randall <khr@golang.org> Reviewed-by: Keith Randall <khr@google.com> Reviewed-by: Keith Randall <khr@golang.org>
This commit is contained in:
parent
134af2e3db
commit
89567a35c1
@ -958,6 +958,11 @@ func reassigned(name *Name) bool {
|
|||||||
if isName(OuterValue(n.X)) {
|
if isName(OuterValue(n.X)) {
|
||||||
return true
|
return true
|
||||||
}
|
}
|
||||||
|
case ORANGE:
|
||||||
|
n := n.(*RangeStmt)
|
||||||
|
if isName(n.Key) || isName(n.Value) {
|
||||||
|
return true
|
||||||
|
}
|
||||||
case OCLOSURE:
|
case OCLOSURE:
|
||||||
n := n.(*ClosureExpr)
|
n := n.(*ClosureExpr)
|
||||||
if Any(n.Func, do) {
|
if Any(n.Func, do) {
|
||||||
|
30
test/fixedbugs/issue59572.go
Normal file
30
test/fixedbugs/issue59572.go
Normal file
@ -0,0 +1,30 @@
|
|||||||
|
// run
|
||||||
|
|
||||||
|
// Copyright 2023 The Go Authors. All rights reserved.
|
||||||
|
// Use of this source code is governed by a BSD-style
|
||||||
|
// license that can be found in the LICENSE file.
|
||||||
|
|
||||||
|
package main
|
||||||
|
|
||||||
|
func foo() {
|
||||||
|
println("foo")
|
||||||
|
}
|
||||||
|
|
||||||
|
func main() {
|
||||||
|
fn := foo
|
||||||
|
for _, fn = range list {
|
||||||
|
fn()
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
var list = []func(){
|
||||||
|
func() {
|
||||||
|
println("1")
|
||||||
|
},
|
||||||
|
func() {
|
||||||
|
println("2")
|
||||||
|
},
|
||||||
|
func() {
|
||||||
|
println("3")
|
||||||
|
},
|
||||||
|
}
|
3
test/fixedbugs/issue59572.out
Normal file
3
test/fixedbugs/issue59572.out
Normal file
@ -0,0 +1,3 @@
|
|||||||
|
1
|
||||||
|
2
|
||||||
|
3
|
Loading…
x
Reference in New Issue
Block a user