From 8b1e8a424afb5d1c347653cc016a94e91cb1318b Mon Sep 17 00:00:00 2001 From: "Bryan C. Mills" Date: Tue, 19 Nov 2019 14:29:10 -0500 Subject: [PATCH] cmd/dist: remove redundant 'go test -race' call MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In CL 207962, I removed a seemingly-redundant -i flag. As it turns out, the -i flag has *two* meanings: “install dependencies”, and “do not actually run the test”. Without the flag, we omit the former behavior, but add the latter. We're about to run specific tests from these binaries on the very next line, so don't preemptively run all of the tests. Updates #30316 Change-Id: Ie3d8a37dc5f6bd98c232b308b0a6a165b5d82f7c Reviewed-on: https://go-review.googlesource.com/c/go/+/207966 Run-TryBot: Bryan C. Mills TryBot-Result: Gobot Gobot Reviewed-by: Brad Fitzpatrick --- src/cmd/dist/test.go | 1 - 1 file changed, 1 deletion(-) diff --git a/src/cmd/dist/test.go b/src/cmd/dist/test.go index 0bd094e00a..2149c697ea 100644 --- a/src/cmd/dist/test.go +++ b/src/cmd/dist/test.go @@ -1327,7 +1327,6 @@ func (t *tester) runFlag(rx string) string { } func (t *tester) raceTest(dt *distTest) error { - t.addCmd(dt, "src", t.goTest(), "-race", "runtime/race", "flag", "os", "os/exec") t.addCmd(dt, "src", t.goTest(), "-race", t.runFlag("Output"), "runtime/race") t.addCmd(dt, "src", t.goTest(), "-race", t.runFlag("TestParse|TestEcho|TestStdinCloseRace|TestClosedPipeRace|TestTypeRace|TestFdRace|TestFdReadRace|TestFileCloseRace"), "flag", "net", "os", "os/exec", "encoding/gob") // We don't want the following line, because it