cybercyst/go
1
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-05-05 15:43:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

runtime: increase GDB version testing requirement to 10 from 7.7

Browse Source 
Bump the required version of GDB up to 10 from 7.7 in the runtime GDB
tests, so as to ensure that we have something that can handle DWARF 5
when running tests. In theory there is some DWARF 5 support on the
version 9 release branch, but we get "Dwarf Error: DW_FORM_addrx"
errors for some archs on builders where GDB 9.2 is installed.

Updates #26379.

Change-Id: I1b7b45f8e4dd1fafccf22f2dda0124458ecf7cba
Reviewed-on: https://go-review.googlesource.com/c/go/+/656836
Auto-Submit: Ian Lance Taylor <iant@google.com>
Reviewed-by: David Chase <drchase@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
This commit is contained in:
Than McIntosh 2025-03-11 21:33:25 -04:00 committed by Gopher Robot
parent c032b04219
commit 8d767ff38d
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/runtime/runtime-gdb_test.go
View File

@ -73,7 +73,9 @@ func checkGdbVersion(t *testing.T) {
if err1 != nil || err2 != nil { if err1 != nil || err2 != nil {
t.Skipf("skipping: can't determine gdb version: %v, %v", err1, err2) t.Skipf("skipping: can't determine gdb version: %v, %v", err1, err2)
} }
if major < 7 || (major == 7 && minor < 7) { // The Go toolchain now generates DWARF 5 by default, which needs
// a GDB version of 10 or above.
if major < 10 {
t.Skipf("skipping: gdb version %d.%d too old", major, minor) t.Skipf("skipping: gdb version %d.%d too old", major, minor)
} }
t.Logf("gdb version %d.%d", major, minor) t.Logf("gdb version %d.%d", major, minor)