cybercyst/go
1
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-05-05 23:53:05 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

internal/lsp/protocol: handle case of an otherwise empty notification

Browse Source 
Some notifications, like exit, have no other arguments, a case the code
was not handling correctly.

Change-Id: Ib5ff536352ba6ad0d09cd80c9d5f0a987abbe500
Reviewed-on: https://go-review.googlesource.com/c/tools/+/200298
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
Run-TryBot: Peter Weinberger <pjw@google.com>
This commit is contained in:
Peter Weinberger 2019-10-10 10:59:39 -04:00
parent 4c025a95b2
commit 8de300cfc2
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
internal/lsp/protocol/log.go
View File

@ -218,9 +218,13 @@ func logIn(outfd io.Writer, data []byte) {
} else { } else {
fmt.Fprintf(&buf, "Result: %s%s", string(*v.Result), eor) fmt.Fprintf(&buf, "Result: %s%s", string(*v.Result), eor)
} }
} else if v.ID == nil && v.Method != "" && v.Params != nil { } else if v.ID == nil && v.Method != "" {
p := "null"
if v.Params != nil {
p = string(*v.Params)
}
fmt.Fprintf(&buf, "Sending notification '%s'.\n", v.Method) fmt.Fprintf(&buf, "Sending notification '%s'.\n", v.Method)
fmt.Fprintf(&buf, "Params: %s%s", *v.Params, eor) fmt.Fprintf(&buf, "Params: %s%s", p, eor)
} else { // for completeness, as it should never happen } else { // for completeness, as it should never happen
buf = strings.Builder{} // undo common Trace buf = strings.Builder{} // undo common Trace
fmt.Fprintf(&buf, "[Error - %s] on read ID?%v method:%q Params:%v Result:%v Error:%v%s", fmt.Fprintf(&buf, "[Error - %s] on read ID?%v method:%q Params:%v Result:%v Error:%v%s",