cybercyst/go
1
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-05-05 23:53:05 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

test: fix issue20014 for noopt builder

Browse Source 
This test is currently overly sensitive to compiler optimizations,
because inlining can affect the order in which cmd/link emits field
references. The order doesn't actually matter though, so this CL just
tweaks the test to sort the tracked fields before printing them.

Updates #51734.

Change-Id: I3b65ca265856b2e1102f40406d5ce34610c70d40
Reviewed-on: https://go-review.googlesource.com/c/go/+/406674
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: David Chase <drchase@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
This commit is contained in:
Matthew Dempsky 2022-05-16 12:14:14 -07:00
parent 6ec46f4707
commit 99d63007a0
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
test/fixedbugs/issue20014.dir/main.go
View File

@ -5,6 +5,7 @@
package main package main
import ( import (
"sort"
"strings" "strings"
"issue20014.dir/a" "issue20014.dir/a"
@ -13,12 +14,17 @@ import (
func main() { func main() {
samePackage() samePackage()
crossPackage() crossPackage()
// Print fields registered with field tracking. // Print fields registered with field tracking.
var fields []string
for _, line := range strings.Split(fieldTrackInfo, "\n") { for _, line := range strings.Split(fieldTrackInfo, "\n") {
if line == "" { if line != "" {
continue fields = append(fields, strings.Split(line, "\t")[0])
} }
println(strings.Split(line, "\t")[0]) }
sort.Strings(fields) // for stable output, regardless of optimizations
for _, field := range fields {
println(field)
} }
} }