From a6ffab6b6743a490151aadfd2f2a79244a84e03a Mon Sep 17 00:00:00 2001 From: Alex Brainman Date: Sat, 19 Aug 2017 13:02:36 +1000 Subject: [PATCH] misc/cgo/testcshared: temporarily skip testing on android For #21513 Change-Id: Ibe9479f8afc6f425779a737a807ff2f839a4f311 Reviewed-on: https://go-review.googlesource.com/57250 TryBot-Result: Gobot Gobot Reviewed-by: Alex Brainman --- misc/cgo/testcshared/cshared_test.go | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/misc/cgo/testcshared/cshared_test.go b/misc/cgo/testcshared/cshared_test.go index 57649a0bfb..3c9a6dd557 100644 --- a/misc/cgo/testcshared/cshared_test.go +++ b/misc/cgo/testcshared/cshared_test.go @@ -250,6 +250,9 @@ func cleanupAndroid(t *testing.T) { // test0: exported symbols in shared lib are accessible. func TestExportedSymbols(t *testing.T) { + if GOOS == "android" { + t.Skip("Skipping failing test, see issue 21513 for details") + } cmd := "testp" bin := cmdToRun(cmd) @@ -272,6 +275,9 @@ func TestExportedSymbols(t *testing.T) { // test1: shared library can be dynamically loaded and exported symbols are accessible. func TestExportedSymbolsWithDynamicLoad(t *testing.T) { + if GOOS == "android" { + t.Skip("Skipping failing test, see issue 21513 for details") + } cmd := "testp" bin := cmdToRun(cmd) @@ -294,6 +300,9 @@ func TestExportedSymbolsWithDynamicLoad(t *testing.T) { // test2: tests libgo2 which does not export any functions. func TestUnexportedSymbols(t *testing.T) { + if GOOS == "android" { + t.Skip("Skipping failing test, see issue 21513 for details") + } cmd := "testp2" libname := "libgo2." + libSuffix bin := cmdToRun(cmd) @@ -333,6 +342,9 @@ func TestUnexportedSymbols(t *testing.T) { // test3: tests main.main is exported on android. func TestMainExportedOnAndroid(t *testing.T) { + if GOOS == "android" { + t.Skip("Skipping failing test, see issue 21513 for details") + } if GOOS != "android" { return } @@ -359,6 +371,9 @@ func TestMainExportedOnAndroid(t *testing.T) { // test4: test signal handlers func TestSignalHandlers(t *testing.T) { + if GOOS == "android" { + t.Skip("Skipping failing test, see issue 21513 for details") + } cmd := "testp4" libname := "libgo4." + libSuffix bin := cmdToRun(cmd) @@ -392,6 +407,9 @@ func TestSignalHandlers(t *testing.T) { // test5: test signal handlers with os/signal.Notify func TestSignalHandlersWithNotify(t *testing.T) { + if GOOS == "android" { + t.Skip("Skipping failing test, see issue 21513 for details") + } cmd := "testp5" libname := "libgo5." + libSuffix bin := cmdToRun(cmd) @@ -424,6 +442,9 @@ func TestSignalHandlersWithNotify(t *testing.T) { } func TestPIE(t *testing.T) { + if GOOS == "android" { + t.Skip("Skipping failing test, see issue 21513 for details") + } switch GOOS { case "linux", "android": break