cybercyst/go
1
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-05-28 02:41:30 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

internal/poll: better panic for invalid write return value

Browse Source 
For #61060

Change-Id: I13cd73b4062cb7bd248d2a4afae06dfa29ac0203
Reviewed-on: https://go-review.googlesource.com/c/go/+/577955
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Commit-Queue: Ian Lance Taylor <iant@google.com>
Reviewed-by: Damien Neil <dneil@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
This commit is contained in:
Ian Lance Taylor 2024-04-10 09:59:20 -07:00 committed by Gopher Robot
parent 7b3c38045b
commit b6778c5230
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/internal/poll/fd_unix.go
View File

@ -7,6 +7,7 @@
package poll
import (
"internal/itoa"
"internal/syscall/unix"
"io"
"sync/atomic"
@ -379,6 +380,14 @@ func (fd *FD) Write(p []byte) (int, error) {
}
n, err := ignoringEINTRIO(syscall.Write, fd.Sysfd, p[nn:max])
if n > 0 {
if n > max-nn {
// This can reportedly happen when using
// some VPN software. Issue #61060.
// If we don't check this we will panic
// with slice bounds out of range.
// Use a more informative panic.
panic("invalid return from write: got " + itoa.Itoa(n) + " from a write of " + itoa.Itoa(max-nn))
}
nn += n
}
if nn == len(p) {