From b7331f9b3a1a5ece290c1a19cd68c58642fe26fb Mon Sep 17 00:00:00 2001
From: Shivakumar GN <shivakumar.gn@gmail.com>
Date: Thu, 27 Sep 2012 01:50:59 +0800
Subject: [PATCH] codereview: use subprocess.call() instead of os.spawnvp() for
 portability

Fixes #4121.

R=golang-dev, minux.ma, dave, r
CC=golang-dev
https://golang.org/cl/6555049
---
 lib/codereview/codereview.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/codereview/codereview.py b/lib/codereview/codereview.py
index 47317ad440..62553257bb 100644
--- a/lib/codereview/codereview.py
+++ b/lib/codereview/codereview.py
@@ -1772,7 +1772,7 @@ def gofmt(ui, repo, *pats, **opts):
 		cmd = ["gofmt", "-l"]
 		if not opts["list"]:
 			cmd += ["-w"]
-		if os.spawnvp(os.P_WAIT, "gofmt", cmd + files) != 0:
+		if subprocess.call(cmd + files) != 0:
 			raise hg_util.Abort("gofmt did not exit cleanly")
 	except hg_error.Abort, e:
 		raise