cybercyst/go
1
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-05-05 15:43:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[release-branch.go1.4] codereview: add release-branch.go1.4 prefix, like for dev branches

Browse Source 
TBR=bradfitz
R=bradfitz
CC=golang-codereviews
https://golang.org/cl/178710043
This commit is contained in:
Russ Cox 2014-12-05 15:27:48 -05:00
parent 75c8a78e61
commit c009bcdd8b
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lib/codereview/codereview.py
View File

@ -314,7 +314,11 @@ class CL(object):
if self.name != "new": if self.name != "new":
s = "code review %s: %s" % (self.name, s) s = "code review %s: %s" % (self.name, s)
typecheck(s, str) typecheck(s, str)
return branch_prefix(ui, repo) + s s = branch_prefix(ui, repo) + s
# Rietveld does a hard reject on any subject > 100 chars. Be sure.
if len(s) >= 100:
s = s[0:95] + "..."
return s
def Upload(self, ui, repo, send_mail=False, gofmt=True, gofmt_just_warn=False, creating=False, quiet=False): def Upload(self, ui, repo, send_mail=False, gofmt=True, gofmt_just_warn=False, creating=False, quiet=False):
if not self.files and not creating: if not self.files and not creating:
@ -409,7 +413,7 @@ class CL(object):
if not self.mailed: if not self.mailed:
pmsg += "I'd like you to review this change to" pmsg += "I'd like you to review this change to"
branch = repo[None].branch() branch = repo[None].branch()
if branch.startswith("dev."): if workbranch(branch) and branch != "default":
pmsg += " the " + branch + " branch of" pmsg += " the " + branch + " branch of"
pmsg += "\n" + repourl + "\n" pmsg += "\n" + repourl + "\n"
else: else:
@ -1921,7 +1925,7 @@ def need_sync():
def branch_prefix(ui, repo): def branch_prefix(ui, repo):
prefix = "" prefix = ""
branch = repo[None].branch() branch = repo[None].branch()
if branch.startswith("dev."): if workbranch(branch) and branch != "default":
prefix = "[" + branch + "] " prefix = "[" + branch + "] "
return prefix return prefix