cybercyst/go
1
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-05-05 15:43:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

internal/lsp/source: don't unconditionally name imports

Browse Source 
In CL 205501 I thoughtlessly set import name to package name, but really
we only want to name imports when goimports would do it. For now, it's
better to not name them and let the usual imports code add a name if
necessary.

Fixes golang/go#35397.

Change-Id: Id0df866f95e5e86ed72b25fbd1a7224c79ee8084
Reviewed-on: https://go-review.googlesource.com/c/tools/+/205657
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This commit is contained in:
Heschi Kreinick 2019-11-06 13:23:43 -05:00
parent 622ba90fc8
commit c2ac6c2a2d
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
internal/lsp/source/completion.go
View File

@ -730,7 +730,6 @@ func (c *completer) lexical() error {
obj := types.NewPkgName(0, nil, pkg.Name(), pkg) obj := types.NewPkgName(0, nil, pkg.Name(), pkg)
c.found(obj, stdScore, &importInfo{ c.found(obj, stdScore, &importInfo{
importPath: pkg.Path(), importPath: pkg.Path(),
name: pkg.Name(),
}) })
} }
} }