From c39e7748f6ebfccd12b373374b6d14018827ea9c Mon Sep 17 00:00:00 2001 From: Rebecca Stambler Date: Thu, 18 Apr 2019 16:40:24 -0400 Subject: [PATCH] internal/lsp: add type to placeholders in completion parameters Fixes golang/go#31547 Change-Id: Ib6e54ae17c778421a49f34d3c60d56b126419a91 Reviewed-on: https://go-review.googlesource.com/c/tools/+/172666 Run-TryBot: Rebecca Stambler TryBot-Result: Gobot Gobot Reviewed-by: Ian Cottrell --- internal/lsp/completion.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/internal/lsp/completion.go b/internal/lsp/completion.go index bfdebddf35..332b779158 100644 --- a/internal/lsp/completion.go +++ b/internal/lsp/completion.go @@ -155,8 +155,7 @@ func labelToInsertText(label string, kind source.CompletionItemKind, insertTextF if i != 0 { b.WriteString(", ") } - p = strings.Split(strings.Trim(p, " "), " ")[0] - fmt.Fprintf(b, "${%v:%v}", i+1, r.Replace(p)) + fmt.Fprintf(b, "${%v:%v}", i+1, r.Replace(strings.TrimSpace(p))) } b.WriteByte(')') return b.String()