cybercyst/go
1
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-05-05 15:43:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

all: address vet reports

Browse Source 
Fixes various problems reported by go vet.

Change-Id: I12a6fdba8f911b21805d8e42903f8f6a5033790a
Reviewed-on: https://go-review.googlesource.com/2163
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This commit is contained in:
Emil Hessman 2014-12-29 06:15:53 +01:00 committed by Brad Fitzpatrick
parent f72c7f7642
commit ca3901c3d8
5 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cmd/html2article/conv.go
View File

@ -223,7 +223,7 @@ func text(n *html.Node) string {
}
// Use original url for Google Docs redirections.
if u, err := url.Parse(href); err != nil {
log.Println("parsing url %q: %v", href, err)
log.Printf("parsing url %q: %v", href, err)
} else if u.Host == "www.google.com" && u.Path == "/url" {
href = u.Query().Get("q")
}

6
container/intsets/sparse_test.go
View File

@ -60,7 +60,7 @@ func TestBasics(t *testing.T) {
// Insert, Len, IsEmpty, Hash, Clear, AppendTo.
func TestMoreBasics(t *testing.T) {
var set intsets.Sparse
set := new(intsets.Sparse)
set.Insert(456)
set.Insert(123)
set.Insert(789)
@ -78,7 +78,7 @@ func TestMoreBasics(t *testing.T) {
}
got := set.AppendTo([]int{-1})
if want := []int{-1, 123, 456, 789}; fmt.Sprint(got) != fmt.Sprint(want) {
t.Errorf("%s.AppendTo: got %v, want %v", got, want)
t.Errorf("%s.AppendTo: got %v, want %v", set, got, want)
}
set.Clear()
@ -107,7 +107,7 @@ func TestTakeMin(t *testing.T) {
}
}
if set.TakeMin(&got) {
t.Errorf("%s.TakeMin returned true", set, got)
t.Errorf("%s.TakeMin returned true", &set)
}
if err := set.Check(); err != nil {
t.Fatalf("check: %s: %#v", err, &set)

2
dashboard/builder/bench.go
View File

@ -118,7 +118,7 @@ func chooseBenchmark(benchBin string, doneBenchs []string) (bench string, procs,
var out bytes.Buffer
err := run(exec.Command(benchBin), allOutput(&out))
if err != nil {
log.Printf("Failed to query benchmark list: %v\n%s", err, out)
log.Printf("Failed to query benchmark list: %v\n%s", err, &out)
last = true
return
}

2
go/loader/loader_test.go
View File

@ -106,7 +106,7 @@ func TestLoadFromArgsSource(t *testing.T) {
t.Fatalf("loadFromArgs(%q) failed: %s", args, err)
}
if len(prog.Created) != 1 {
t.Errorf("loadFromArgs(%q): got %d items, want 1", len(prog.Created))
t.Errorf("loadFromArgs(%q): got %d items, want 1", args, len(prog.Created))
}
if len(prog.Created) > 0 {
path := prog.Created[0].Pkg.Path()

4
go/types/api_test.go
View File

@ -813,10 +813,10 @@ func main() {
got := sig.Recv().Type()
want := sel.Recv()
if !Identical(got, want) {
t.Errorf("%s: Recv() = %s, want %s", got, want)
t.Errorf("%s: Recv() = %s, want %s", syntax, got, want)
}
} else if sig != nil && sig.Recv() != nil {
t.Error("%s: signature has receiver %s", sig, sig.Recv().Type())
t.Errorf("%s: signature has receiver %s", sig, sig.Recv().Type())
}
}
// Assert that all wantOut entries were used exactly once.