cybercyst/go
1
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-05-05 15:43:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

test: switch fieldtrack test to use GOEXPERIMENT

Browse Source 
Now that we can set GOEXPERIMENT at build time, we no longer need
-d=fieldtrack in the compiler to enabled field tracking at build time.
Switch the one test that uses -d=fieldtrack to use GOEXPERIMENT
instead so we can eliminate this debug flag and centralize on
GOEXPERIMENT.

Updates #42681.

Change-Id: I14c352c9a97187b9c5ec8027ff672d685f22f543
Reviewed-on: https://go-review.googlesource.com/c/go/+/302969
Trust: Austin Clements <austin@google.com>
Run-TryBot: Austin Clements <austin@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
This commit is contained in:
Austin Clements 2021-03-18 11:35:45 -04:00
parent bdbba22404
commit d3ab6b5049
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/fixedbugs/issue42686.go
View File

@ -1,4 +1,4 @@
// compile -d=fieldtrack // compile -goexperiment fieldtrack
// Copyright 2020 The Go Authors. All rights reserved. // Copyright 2020 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style // Use of this source code is governed by a BSD-style

6
test/run.go
View File

@ -513,7 +513,7 @@ func (t *test) run() {
return return
} }
var args, flags []string var args, flags, runenv []string
var tim int var tim int
wantError := false wantError := false
wantAuto := false wantAuto := false
@ -572,6 +572,9 @@ func (t *test) run() {
if err != nil { if err != nil {
t.err = fmt.Errorf("need number of seconds for -t timeout, got %s instead", args[0]) t.err = fmt.Errorf("need number of seconds for -t timeout, got %s instead", args[0])
} }
case "-goexperiment": // set GOEXPERIMENT environment
args = args[1:]
runenv = append(runenv, "GOEXPERIMENT="+args[0])
default: default:
flags = append(flags, args[0]) flags = append(flags, args[0])
@ -628,6 +631,7 @@ func (t *test) run() {
if tempDirIsGOPATH { if tempDirIsGOPATH {
cmd.Env = append(cmd.Env, "GOPATH="+t.tempDir) cmd.Env = append(cmd.Env, "GOPATH="+t.tempDir)
} }
cmd.Env = append(cmd.Env, runenv...)
var err error var err error