cybercyst/go
1
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-05-05 23:53:05 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[release-branch.go1.18] net: disable TestLookupDotsWithRemoteSource and TestLookupGoogleSRV

Browse Source 
These tests fail consistently due to a DNS change causing widespread
trybot outages.

For #56707.
Fixes #56709.

Change-Id: Iebdf91254a922a48880021198f0f12f6bc16b6e7
Reviewed-on: https://go-review.googlesource.com/c/go/+/449640
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Michael Knyszek <mknyszek@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Damien Neil <dneil@google.com>
(cherry picked from commit 97765249082b6835c77517a4e63bb38cfd6db97b)
Reviewed-on: https://go-review.googlesource.com/c/go/+/449505
Reviewed-by: Ian Lance Taylor <iant@google.com>
This commit is contained in:
Michael Anthony Knyszek 2022-11-11 17:26:45 +00:00 committed by Michael Knyszek
parent a3dce12768
commit d96e584773
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/net/lookup_test.go
View File

@ -71,6 +71,10 @@ var lookupGoogleSRVTests = []struct {
var backoffDuration = [...]time.Duration{time.Second, 5 * time.Second, 30 * time.Second} var backoffDuration = [...]time.Duration{time.Second, 5 * time.Second, 30 * time.Second}
func TestLookupGoogleSRV(t *testing.T) { func TestLookupGoogleSRV(t *testing.T) {
// TODO(mknyszek): Figure out next steps for this test. This is just
// a quick fix.
t.Skip("fails consistently due to an upstream DNS change; see #56707.")
t.Parallel() t.Parallel()
mustHaveExternalNetwork(t) mustHaveExternalNetwork(t)
@ -631,6 +635,10 @@ func TestLookupDotsWithLocalSource(t *testing.T) {
} }
func TestLookupDotsWithRemoteSource(t *testing.T) { func TestLookupDotsWithRemoteSource(t *testing.T) {
// TODO(mknyszek): Figure out next steps for this test. This is just
// a quick fix.
t.Skip("fails consistently due to an upstream DNS change; see #56707.")
if runtime.GOOS == "darwin" || runtime.GOOS == "ios" { if runtime.GOOS == "darwin" || runtime.GOOS == "ios" {
testenv.SkipFlaky(t, 27992) testenv.SkipFlaky(t, 27992)
} }