From e3d3e115e878a70af06c09960a924c5d0fa2710c Mon Sep 17 00:00:00 2001 From: Sjoerd Siebinga Date: Thu, 22 Aug 2019 16:36:20 +0200 Subject: [PATCH] cmd/go: add a test for -sectcreate in LDFLAGS MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit It was already covered by a regex pattern, but it didn't have a test. To fix the issue for good, added regression test. Fixes #28832. Change-Id: I861e3bed92d3b9484fd8671270dbd2e264b10d2d Reviewed-on: https://go-review.googlesource.com/c/go/+/191311 Reviewed-by: Daniel Martí Reviewed-by: Ian Lance Taylor Run-TryBot: Daniel Martí TryBot-Result: Gobot Gobot --- src/cmd/go/internal/work/security_test.go | 1 + 1 file changed, 1 insertion(+) diff --git a/src/cmd/go/internal/work/security_test.go b/src/cmd/go/internal/work/security_test.go index fd8caeab4e..a3a1d7d56c 100644 --- a/src/cmd/go/internal/work/security_test.go +++ b/src/cmd/go/internal/work/security_test.go @@ -143,6 +143,7 @@ var goodLinkerFlags = [][]string{ {"-L", "framework"}, {"-framework", "Chocolate"}, {"-v"}, + {"-Wl,-sectcreate,__TEXT,__info_plist,${SRCDIR}/Info.plist"}, {"-Wl,-framework", "-Wl,Chocolate"}, {"-Wl,-framework,Chocolate"}, {"-Wl,-unresolved-symbols=ignore-all"},