From e43ef8dda2d2baeca7f42a50cc92f527e6826b9f Mon Sep 17 00:00:00 2001 From: Ian Lance Taylor Date: Mon, 12 Oct 2020 17:19:49 -0700 Subject: [PATCH] test: add test that fails with gofrontend The gofrontend code doesn't correctly handle inlining a function that refers to a constant with methods. For #35739 Change-Id: I6bd0b5cd4272dbe9969634b4821e668acacfdcf9 Reviewed-on: https://go-review.googlesource.com/c/go/+/261662 Trust: Ian Lance Taylor Run-TryBot: Ian Lance Taylor TryBot-Result: Go Bot Reviewed-by: Cherry Zhang --- test/fixedbugs/issue35739.dir/a.go | 15 +++++++++++++++ test/fixedbugs/issue35739.dir/b.go | 11 +++++++++++ test/fixedbugs/issue35739.go | 9 +++++++++ 3 files changed, 35 insertions(+) create mode 100644 test/fixedbugs/issue35739.dir/a.go create mode 100644 test/fixedbugs/issue35739.dir/b.go create mode 100644 test/fixedbugs/issue35739.go diff --git a/test/fixedbugs/issue35739.dir/a.go b/test/fixedbugs/issue35739.dir/a.go new file mode 100644 index 0000000000..b79503e996 --- /dev/null +++ b/test/fixedbugs/issue35739.dir/a.go @@ -0,0 +1,15 @@ +// Copyright 2020 The Go Authors. All rights reserved. +// Use of this source code is governed by a BSD-style +// license that can be found in the LICENSE file. + +package a + +type myError string + +func (e myError) Error() string { return string(e) } + +const myErrorVal myError = "error" + +func IsMyError(err error) bool { + return err == error(myErrorVal) +} diff --git a/test/fixedbugs/issue35739.dir/b.go b/test/fixedbugs/issue35739.dir/b.go new file mode 100644 index 0000000000..8d22aac8d6 --- /dev/null +++ b/test/fixedbugs/issue35739.dir/b.go @@ -0,0 +1,11 @@ +// Copyright 2020 The Go Authors. All rights reserved. +// Use of this source code is governed by a BSD-style +// license that can be found in the LICENSE file. + +package b + +import "./a" + +func F(err error) bool { + return a.IsMyError(err) +} diff --git a/test/fixedbugs/issue35739.go b/test/fixedbugs/issue35739.go new file mode 100644 index 0000000000..26f09d8c1b --- /dev/null +++ b/test/fixedbugs/issue35739.go @@ -0,0 +1,9 @@ +// compiledir + +// Copyright 2020 The Go Authors. All rights reserved. +// Use of this source code is governed by a BSD-style +// license that can be found in the LICENSE file. + +// Issue 35739: gccgo inlining error with constant with method. + +package ignored