From ea9b1bd08b2961f5ca4b8b838d88f77c51f53c9c Mon Sep 17 00:00:00 2001 From: Robert Daniel Kortschak Date: Tue, 8 Jul 2014 22:40:37 -0400 Subject: [PATCH] go.tools/playground/socket: add support for Native Client on arm LGTM=minux R=adg, minux CC=golang-codereviews https://golang.org/cl/110900043 --- playground/socket/socket.go | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/playground/socket/socket.go b/playground/socket/socket.go index ae4b481c07..02e1a9c5b7 100644 --- a/playground/socket/socket.go +++ b/playground/socket/socket.go @@ -341,7 +341,7 @@ func (p *process) naclCmd(bin string) (*exec.Cmd, error) { if err != nil { return nil, err } - var ldr string + var args []string env := []string{ "NACLENV_GOOS=" + runtime.GOOS, "NACLENV_GOROOT=/go", @@ -349,16 +349,19 @@ func (p *process) naclCmd(bin string) (*exec.Cmd, error) { } switch runtime.GOARCH { case "amd64": - env = append(env, "NACLENV_GOARCH=amd64") - ldr = "sel_ldr_x86_64" + env = append(env, "NACLENV_GOARCH=amd64p32") + args = []string{"sel_ldr_x86_64"} case "386": env = append(env, "NACLENV_GOARCH=386") - ldr = "sel_ldr_x86_32" + args = []string{"sel_ldr_x86_32"} + case "arm": + env = append(env, "NACLENV_GOARCH=arm") + args = []string{"nacl_helper_bootstrap_arm", "sel_ldr_arm", "--reserved_at_zero=0xXXXXXXXXXXXXXXXX"} default: return nil, errors.New("native client does not support GOARCH=" + runtime.GOARCH) } - cmd := p.cmd("", ldr, "-l", "/dev/null", "-S", "-e", bin) + cmd := p.cmd("", append(args, "-l", "/dev/null", "-S", "-e", bin)...) cmd.Env = append(cmd.Env, env...) return cmd, nil