cybercyst/go
1
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-05-05 23:53:05 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

runtime: remove VZEROUPPER in asyncPreempt on darwin/amd64

Browse Source 
Updates #37174
Updates #49233
Fixes #41152

Change-Id: I35b148c8bc132f02dd6a5a6bb48b711fb5c5df9e
Reviewed-on: https://go-review.googlesource.com/c/go/+/560955
Reviewed-by: Keith Randall <khr@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
This commit is contained in:
Cuong Manh Le 2024-02-03 10:47:28 +07:00 committed by Gopher Robot
parent 78c0ea5df7
commit fe87b586c0
2 changed files with 0 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/runtime/mkpreempt.go
View File

@ -264,19 +264,6 @@ func genAMD64() {
l.save() l.save()
// Apparently, the signal handling code path in darwin kernel leaves
// the upper bits of Y registers in a dirty state, which causes
// many SSE operations (128-bit and narrower) become much slower.
// Clear the upper bits to get to a clean state. See issue #37174.
// It is safe here as Go code don't use the upper bits of Y registers.
p("#ifdef GOOS_darwin")
p("#ifndef hasAVX")
p("CMPB internal∕cpu·X86+const_offsetX86HasAVX(SB), $0")
p("JE 2(PC)")
p("#endif")
p("VZEROUPPER")
p("#endif")
lSSE.save() lSSE.save()
p("CALL ·asyncPreempt2(SB)") p("CALL ·asyncPreempt2(SB)")
lSSE.restore() lSSE.restore()

7
src/runtime/preempt_amd64.s
View File

@ -27,13 +27,6 @@ TEXT ·asyncPreempt(SB),NOSPLIT|NOFRAME,$0-0
MOVQ R13, 88(SP) MOVQ R13, 88(SP)
MOVQ R14, 96(SP) MOVQ R14, 96(SP)
MOVQ R15, 104(SP) MOVQ R15, 104(SP)
#ifdef GOOS_darwin
#ifndef hasAVX
CMPB internal∕cpu·X86+const_offsetX86HasAVX(SB), $0
JE 2(PC)
#endif
VZEROUPPER
#endif
MOVUPS X0, 112(SP) MOVUPS X0, 112(SP)
MOVUPS X1, 128(SP) MOVUPS X1, 128(SP)
MOVUPS X2, 144(SP) MOVUPS X2, 144(SP)