3 Commits

Author	SHA1	Message	Date
Ian Cottrell	a8f40b3f4d	internal/jsonrpc2: split main loop from construction to fix race ... This changes the basic API of a jsonrpc2 connection to run the read loop as a method rather than in a go routine launched in the NewConn. This allows the handler to be created and bound between construction and the read loop starting, which fixes the race. Fixes golang/go#30091 Change-Id: I8201175affe431819cf473e5194d70c019f58425 Reviewed-on: https://go-review.googlesource.com/c/tools/+/170003 Run-TryBot: Ian Cottrell <iancottrell@google.com> Reviewed-by: Rebecca Stambler <rstambler@golang.org>	2019-03-29 19:31:51 +00:00
Ian Cottrell	dbb4d4be53	lsp/internal: fix incorrectly formatted file ... Change-Id: Ibef9c7d5ce0abfa26ba98744c26b54d843227c23 Reviewed-on: https://go-review.googlesource.com/c/162077 Run-TryBot: Ian Cottrell <iancottrell@google.com> Reviewed-by: Rebecca Stambler <rstambler@golang.org>	2019-02-13 16:29:12 +00:00
Ian Cottrell	44bee7e801	internal/lsp: changing server noun to serve verb ... Also adding in --remote support and using it to implement the equivalent functionality of the external forward command Also adding in --listen as a replacement for --port as it is more flexible, specifically it allows localhost:port which is helpful in environments where opening remotely accesible ports is problematic. Change-Id: I5de1cea7dd6f1ee46e7423f3be2a4caca6f040b2 Reviewed-on: https://go-review.googlesource.com/c/161658 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>	2019-02-11 22:49:14 +00:00