[release-branch.go1.23] go1.23rc1

Change-Id: Ied4bb63f49d13bd7d421cf9cb269220974641b89 Reviewed-on: https://go-review.googlesource.com/c/go/+/593897 Auto-Submit: David Chase <drchase@google.com> Reviewed-by: David Chase <drchase@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Gopher Robot <gobot@golang.org>
[release-branch.go1.23] internal/godebugs: fix old value for httpservecontentkeepheaders
2025-05-07 08:32:59 +00:00 · 2024-06-21 16:32:19 +00:00 · 2024-06-20 19:14:07 +00:00 · 2024-06-20 19:13:52 +00:00 · 2024-06-20 19:13:34 +00:00 · 2024-06-18 21:25:28 +00:00
6 changed files with 45 additions and 8 deletions
--- a/2
+++ b/2
@ -0,0 +1,2 @@
+go1.23rc1
+time 2024-06-20T19:20:56Z
--- a/codereview.cfg
+++ b/codereview.cfg
@ -1 +1,2 @@
-branch: master
+branch: release-branch.go1.23
+parent-branch: master
--- a/src/cmd/compile/internal/noder/writer.go
+++ b/src/cmd/compile/internal/noder/writer.go
@ -543,7 +543,7 @@ func (pw *pkgWriter) typIdx(typ types2.Type, dict *writerDict) typeInfo {

 	case *types2.Alias:
 		w.Code(pkgbits.TypeNamed)
-		w.namedType(typ.Obj(), nil)
+		w.namedType(splitAlias(typ))

 	case *types2.TypeParam:
 		w.derived = true
@ -2958,6 +2958,9 @@ func objTypeParams(obj types2.Object) *types2.TypeParamList {
 		if !obj.IsAlias() {
 			return obj.Type().(*types2.Named).TypeParams()
 		}
+		if alias, ok := obj.Type().(*types2.Alias); ok {
+			return alias.TypeParams()
+		}
 	}
 	return nil
 }
@ -2974,6 +2977,14 @@ func splitNamed(typ *types2.Named) (*types2.TypeName, *types2.TypeList) {
 	return typ.Obj(), typ.TypeArgs()
 }

+// splitAlias is like splitNamed, but for an alias type.
+func splitAlias(typ *types2.Alias) (*types2.TypeName, *types2.TypeList) {
+	orig := typ.Origin()
+	base.Assertf(typ.Obj() == orig.Obj(), "alias type %v has object %v, but %v has object %v", typ, typ.Obj(), orig, orig.Obj())
+
+	return typ.Obj(), typ.TypeArgs()
+}
+
 func asPragmaFlag(p syntax.Pragma) ir.PragmaFlag {
 	if p == nil {
 		return 0
--- a/src/internal/godebugs/table.go
+++ b/src/internal/godebugs/table.go
@ -36,7 +36,7 @@ var All = []Info{
 	{Name: "http2server", Package: "net/http"},
 	{Name: "httplaxcontentlength", Package: "net/http", Changed: 22, Old: "1"},
 	{Name: "httpmuxgo121", Package: "net/http", Changed: 22, Old: "1"},
-	{Name: "httpservecontentkeepheaders", Package: "net/http", Changed: 23, Old: "0"},
+	{Name: "httpservecontentkeepheaders", Package: "net/http", Changed: 23, Old: "1"},
 	{Name: "installgoroot", Package: "go/build"},
 	{Name: "jstmpllitinterp", Package: "html/template", Opaque: true}, // bug #66217: remove Opaque
 	//{Name: "multipartfiles", Package: "mime/multipart"},
--- a/src/internal/syscall/unix/at_sysnum_dragonfly.go
+++ b/src/internal/syscall/unix/at_sysnum_dragonfly.go
@ -6,15 +6,15 @@ package unix

 import "syscall"

-const unlinkatTrap uintptr = syscall.SYS_UNLINKAT
-const openatTrap uintptr = syscall.SYS_OPENAT
-const fstatatTrap uintptr = syscall.SYS_FSTATAT
-
 const (
+	unlinkatTrap uintptr = syscall.SYS_UNLINKAT
+	openatTrap   uintptr = syscall.SYS_OPENAT
+	fstatatTrap  uintptr = syscall.SYS_FSTATAT
+
 	AT_EACCESS          = 0x4
 	AT_FDCWD            = 0xfffafdcd
 	AT_REMOVEDIR        = 0x2
 	AT_SYMLINK_NOFOLLOW = 0x1

-	UTIME_OMIT = -0x1
+	UTIME_OMIT = -0x2
 )
--- a/test/fixedbugs/issue68054.go
+++ b/test/fixedbugs/issue68054.go
@ -0,0 +1,23 @@
+// compile -goexperiment aliastypeparams
+
+// Copyright 2024 The Go Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+package p
+
+type Seq[V any] = func(yield func(V) bool)
+
+func f[E any](seq Seq[E]) {
+	return
+}
+
+func g() {
+	f(Seq[int](nil))
+}
+
+type T[P any] struct{}
+
+type A[P any] = T[P]
+
+var _ A[int]
Author	SHA1	Message	Date
Gopher Robot	7dff7439dc	[release-branch.go1.23] go1.23rc1 Change-Id: Ied4bb63f49d13bd7d421cf9cb269220974641b89 Reviewed-on: https://go-review.googlesource.com/c/go/+/593897 Auto-Submit: David Chase <drchase@google.com> Reviewed-by: David Chase <drchase@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Gopher Robot <gobot@golang.org>	2024-06-21 16:32:19 +00:00
Damien Neil	62c3a6350b	[release-branch.go1.23] internal/godebugs: fix old value for httpservecontentkeepheaders The pre-Go 1.23 behavior is httpservecontentkeepheaders=1. For #66343 Change-Id: If6f92853b38522f19a8908ff11ac49b12f3dc3e0 Reviewed-on: https://go-review.googlesource.com/c/go/+/593775 Reviewed-by: David Chase <drchase@google.com> Auto-Submit: Damien Neil <dneil@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-on: https://go-review.googlesource.com/c/go/+/593795 Reviewed-by: Damien Neil <dneil@google.com> Reviewed-by: Michael Pratt <mpratt@google.com>	2024-06-20 19:14:07 +00:00
Cuong Manh Le	eba9e08766	[release-branch.go1.23] cmd/compile: support generic alias type Type parameters on aliases are now allowed after #46477 accepted. Updates #46477 Fixes #68054 Change-Id: Ic2e3b6f960a898163f47666e3a6bfe43b8cc22e2 Reviewed-on: https://go-review.googlesource.com/c/go/+/593715 Reviewed-by: Robert Griesemer <gri@google.com> Reviewed-by: Matthew Dempsky <mdempsky@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Robert Griesemer <gri@google.com> Reviewed-on: https://go-review.googlesource.com/c/go/+/593797 Reviewed-by: Michael Pratt <mpratt@google.com>	2024-06-20 19:13:52 +00:00
Kir Kolyshkin	f3bdcda88a	[release-branch.go1.23] internal/syscall/unix: fix UTIME_OMIT for dragonfly CL 219638 added UTIME_OMIT values for various systems. The value for DragonFly BSD appears to be incorrect. The correct value is -2 (see references below), while -1 is used for UTIME_NOW. As a result, timestamp is changed to the current time instead of not touching. This should have been caught by the accompanying test case, TestChtimesWithZeroTimes, but its failures are essentially skipped on dragonfly (this is being fixed separately in a followup CL 591535). Improve formatting while at it. References: - https://github.com/DragonFlyBSD/DragonFlyBSD/blob/965b380e9609/sys/sys/stat.h#L284 - https://go.googlesource.com/sys/+/refs/tags/v0.20.0/unix/zerrors_dragonfly_amd64.go#1421 Change-Id: I432360ca982c84b7cd70d0cf01d860af9ff985fa Reviewed-on: https://go-review.googlesource.com/c/go/+/589496 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Cherry Mui <cherryyz@google.com> Auto-Submit: Ian Lance Taylor <iant@golang.org> Reviewed-by: Ian Lance Taylor <iant@google.com> Commit-Queue: Ian Lance Taylor <iant@golang.org> Reviewed-on: https://go-review.googlesource.com/c/go/+/593796 Reviewed-by: Michael Pratt <mpratt@google.com>	2024-06-20 19:13:34 +00:00
David Chase	362f22d2d2	[release-branch.go1.23] update codereview.cfg for release-branch.go1.23 Change-Id: Ib335bc903e2b8d5b7be6a158a6debe5db48e79a4 Reviewed-on: https://go-review.googlesource.com/c/go/+/593535 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: David Chase <drchase@google.com> Reviewed-by: Michael Pratt <mpratt@google.com>	2024-06-18 21:25:28 +00:00