Cuong Manh Le
bdb480fd62
cmd/compile: fix mishandling of unsafe-uintptr arguments in go/defer
...
Currently, the statement:
go g(uintptr(f()))
gets rewritten into:
tmp := f()
newproc(8, g, uintptr(tmp))
runtime.KeepAlive(tmp)
which doesn't guarantee that tmp is still alive by time the g call is
scheduled to run.
This CL fixes the issue, by wrapping g call in a closure:
go func(p unsafe.Pointer) {
g(uintptr(p))
}(f())
then this will be rewritten into:
tmp := f()
go func(p unsafe.Pointer) {
g(uintptr(p))
runtime.KeepAlive(p)
}(tmp)
runtime.KeepAlive(tmp) // superfluous, but harmless
So the unsafe.Pointer p will be kept alive at the time g call runs.
Updates #24491
Change-Id: Ic10821251cbb1b0073daec92b82a866c6ebaf567
Reviewed-on: https://go-review.googlesource.com/c/go/+/253457
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
2020-09-09 07:50:01 +00:00
..
2017-01-20 05:55:53 +00:00
2019-03-06 18:53:12 +00:00
2020-03-25 22:22:20 +00:00
2019-04-02 16:34:03 +00:00
2020-08-29 08:02:52 +00:00
2016-05-02 13:43:18 +00:00
2020-09-09 07:50:01 +00:00
2016-05-02 13:43:18 +00:00
2015-10-07 14:37:44 +00:00
2019-11-06 09:09:59 +00:00
2017-03-16 02:44:16 +00:00
2019-09-08 17:28:20 +00:00
2019-09-16 15:30:51 +00:00
2019-04-16 16:20:39 +00:00
2018-03-01 21:11:16 +00:00
2019-08-28 19:27:20 +00:00
2016-05-02 13:43:18 +00:00
2020-02-21 22:57:52 +00:00
2016-07-06 20:48:41 +00:00
2016-04-24 21:36:52 +00:00
2016-05-02 13:43:18 +00:00
2018-04-05 22:01:17 +00:00
2017-01-20 05:55:53 +00:00
2016-05-02 13:43:18 +00:00
2018-04-09 18:57:37 +00:00
2018-05-06 04:28:23 +00:00
2018-05-06 04:28:23 +00:00
2017-05-11 13:53:54 +00:00
2014-10-06 17:16:39 -04:00
2016-03-17 04:20:02 +00:00
2020-03-29 17:12:56 +00:00
2016-05-02 13:43:18 +00:00
2018-05-29 02:39:16 +00:00
2018-11-26 14:06:28 +00:00
2020-03-29 17:12:56 +00:00
2019-03-06 20:04:07 +00:00
2014-10-31 11:08:27 -04:00
2015-01-29 13:07:30 +00:00
2019-09-08 17:28:20 +00:00
2018-10-06 15:40:03 +00:00
2018-08-14 09:19:38 +00:00
2015-06-26 03:38:21 +00:00
2019-03-14 21:00:20 +00:00
2017-03-15 22:45:17 +00:00
2017-03-15 22:45:17 +00:00
2017-03-15 22:45:17 +00:00
2019-09-26 18:45:53 +00:00
2016-05-02 13:43:18 +00:00
2019-03-28 17:46:55 +00:00
2015-07-11 14:36:33 +00:00
2015-07-11 14:36:33 +00:00
2016-05-02 13:43:18 +00:00
2019-09-26 23:54:29 +00:00
2016-05-02 13:43:18 +00:00
2016-10-04 17:10:47 +00:00
2019-09-06 23:15:48 +00:00
2019-03-14 21:00:20 +00:00
2019-09-06 23:15:48 +00:00
2016-05-02 13:43:18 +00:00
2016-05-02 13:43:18 +00:00
2020-02-26 16:54:17 +00:00
2019-10-16 00:05:37 +00:00
2018-05-31 17:36:45 +00:00
2020-04-13 21:56:15 +00:00
2020-04-21 16:47:01 +00:00
2016-05-02 13:43:18 +00:00
2016-05-02 13:43:18 +00:00
2016-05-02 13:43:18 +00:00
2016-05-02 13:43:18 +00:00
2020-04-21 20:49:34 +00:00
2020-04-21 20:49:34 +00:00
2016-05-02 13:43:18 +00:00
2019-04-02 16:34:03 +00:00
2020-08-15 03:09:52 +00:00
2019-09-16 15:30:51 +00:00
2019-09-16 15:30:51 +00:00
2019-09-16 15:30:51 +00:00
2019-09-16 15:30:51 +00:00
2019-09-06 01:35:46 +00:00
2019-11-16 20:31:45 +00:00
2019-09-25 17:07:09 +00:00
2019-09-16 15:30:51 +00:00
2019-09-03 17:52:06 +00:00
2019-09-03 17:52:06 +00:00
2019-10-07 18:50:14 +00:00
2019-04-17 22:55:26 +00:00
2019-04-17 16:36:56 +00:00
2020-03-31 21:51:51 +00:00
2019-09-16 15:30:51 +00:00
2019-09-16 15:30:51 +00:00
2019-08-28 19:27:20 +00:00
2019-04-17 19:09:15 +00:00
2019-09-03 17:52:06 +00:00
2014-12-08 22:22:58 +00:00
2019-09-08 17:28:20 +00:00
2016-09-14 16:39:47 +00:00
2016-05-02 13:43:18 +00:00
2016-05-02 13:43:18 +00:00
2016-05-02 13:43:18 +00:00
2016-05-02 13:43:18 +00:00
2016-05-02 13:43:18 +00:00
2016-05-02 13:43:18 +00:00
2018-04-30 19:39:18 +00:00
2018-05-08 21:15:48 +00:00
2016-05-02 13:43:18 +00:00
2019-10-10 19:38:06 +00:00
2017-04-19 02:27:58 +00:00
2019-03-07 21:05:15 +00:00
2018-05-31 17:36:45 +00:00
2016-05-02 13:43:18 +00:00
2017-03-24 20:07:15 +00:00
2017-02-10 01:22:30 +00:00
2016-05-02 13:43:18 +00:00
2016-05-02 13:43:18 +00:00
2016-05-02 13:43:18 +00:00
2019-09-08 17:28:20 +00:00
2016-05-02 13:43:18 +00:00
2019-03-18 20:10:55 +00:00
2019-11-04 20:19:15 +00:00
2017-04-24 12:37:49 +00:00
2015-09-05 02:25:01 +00:00
2020-02-26 14:44:24 +00:00
2019-01-08 21:54:04 +00:00
2019-01-08 21:54:04 +00:00
2017-03-03 21:29:32 +00:00
2018-08-30 22:48:28 +00:00
2020-03-25 01:11:15 +00:00
2018-03-13 20:34:03 +00:00
2020-04-03 21:43:52 +00:00
2020-03-25 01:11:15 +00:00
2016-09-19 19:03:01 +00:00
2017-04-12 14:27:45 +00:00
2016-05-02 13:43:18 +00:00
2019-11-18 14:40:07 +00:00
2016-05-02 13:43:18 +00:00
2019-08-28 19:27:20 +00:00
2018-04-30 19:39:18 +00:00
2019-10-03 18:08:32 +00:00
2019-11-01 20:13:05 +00:00
2019-02-19 22:45:09 +00:00
2016-05-02 13:43:18 +00:00
2019-09-03 19:33:04 +00:00
2019-09-16 15:30:51 +00:00
2020-01-29 16:34:44 +00:00
2018-04-05 10:53:40 +00:00
2019-09-26 18:47:12 +00:00
2020-04-19 07:51:23 +00:00
2020-04-19 07:51:23 +00:00
2017-04-24 12:37:49 +00:00
2020-05-07 17:50:24 +00:00
2017-04-24 12:37:49 +00:00
2014-08-06 17:02:55 -04:00
2018-05-08 21:15:16 +00:00
2014-10-27 18:59:02 -04:00
2017-09-03 14:29:38 +00:00
2016-03-17 00:38:15 +00:00
2017-10-12 20:50:20 +00:00
2016-05-02 13:43:18 +00:00
2017-10-12 20:50:20 +00:00
2018-04-06 15:39:11 +00:00
2016-05-02 13:43:18 +00:00
2016-05-02 13:43:18 +00:00
2016-05-02 13:43:18 +00:00
2019-05-11 03:02:33 +00:00
2018-11-26 14:13:53 +00:00
2016-05-02 13:43:18 +00:00
2018-11-27 15:36:08 +00:00
2018-11-26 14:13:53 +00:00
2018-11-26 14:13:53 +00:00
2018-11-26 14:13:53 +00:00
2018-11-26 14:13:53 +00:00
2020-04-07 21:51:03 +00:00
2020-08-25 01:46:05 +00:00
2018-12-05 21:54:54 +00:00
2018-11-02 19:53:59 +00:00
2020-04-03 21:43:52 +00:00
2016-10-25 22:28:40 +00:00
2019-09-08 17:28:20 +00:00
2018-04-30 19:39:18 +00:00
2016-09-13 20:06:13 +00:00
2018-05-31 17:36:45 +00:00
2017-09-26 04:08:38 +00:00
2018-05-31 17:36:45 +00:00
2020-07-30 17:23:11 +00:00
2017-09-12 05:50:54 +00:00
2020-08-28 21:23:32 +00:00
2016-05-02 13:43:18 +00:00
2019-09-03 20:41:29 +00:00
2016-05-02 13:43:18 +00:00
2018-01-10 01:35:45 +00:00
2017-04-24 12:37:49 +00:00
2016-05-02 13:43:18 +00:00
2016-03-11 21:19:20 +00:00
2016-03-11 21:19:20 +00:00
2016-03-11 21:19:20 +00:00
2016-03-11 22:07:02 +00:00
2020-04-19 03:12:32 +00:00
2020-04-19 03:12:32 +00:00
2019-09-06 23:15:48 +00:00
2016-05-02 13:43:18 +00:00
2016-05-02 13:43:18 +00:00
2017-02-11 21:46:21 +00:00
2018-03-01 21:11:16 +00:00
2016-05-02 13:43:18 +00:00
2016-05-02 13:43:18 +00:00
2016-05-02 13:43:18 +00:00
2016-05-02 13:43:18 +00:00
2016-05-02 13:43:18 +00:00
2016-05-02 13:43:18 +00:00
2020-03-25 14:19:25 +00:00
2016-05-02 13:43:18 +00:00
2020-08-25 16:06:36 +00:00
2019-09-06 23:15:48 +00:00
2016-05-02 13:43:18 +00:00
2018-05-31 17:36:45 +00:00
2019-11-18 14:40:07 +00:00
2018-12-03 16:48:21 +00:00
2016-05-02 13:43:18 +00:00
2016-05-02 13:43:18 +00:00
2016-05-02 13:43:18 +00:00
2016-05-02 13:43:18 +00:00
2018-03-08 22:25:25 +00:00
2018-10-03 19:54:29 +00:00
2018-10-03 19:54:16 +00:00
2018-10-03 19:54:16 +00:00
2018-06-12 19:10:34 +00:00
2019-09-08 17:28:20 +00:00
2016-05-02 13:43:18 +00:00
2016-08-19 01:10:21 +00:00
2018-10-16 21:54:35 +00:00
2017-02-02 17:36:43 +00:00
2017-05-19 18:11:51 +00:00
2015-11-03 18:57:18 +00:00
2014-07-01 09:20:51 +02:00
2020-04-17 13:30:49 +00:00
2015-09-06 23:50:51 +00:00
2019-09-11 23:33:11 +00:00
2019-10-28 23:34:13 +00:00
2018-10-04 00:49:49 +00:00
2019-11-05 00:26:30 +00:00
2019-11-05 00:26:30 +00:00
2016-07-06 20:48:41 +00:00
2016-05-02 13:43:18 +00:00
2016-05-02 13:43:18 +00:00
2020-06-08 15:31:43 +00:00
2020-04-14 17:34:31 +00:00
2016-12-23 17:35:24 +00:00