mirror of
https://github.com/golang/go.git
synced 2025-05-19 14:24:46 +00:00
0cb45bac01
These tests are checking the output of test functions that call the Helper methods. However, they were reaching into package internals instead of running those test functions as actual tests. That not only produced significant differences in formatting (such as indentation for subtests), but also caused test flags such as "-failfast" passed for the overall test run to interfere with the output formatting. Now, we run the test functions as real tests in a subprocess, so that we get the real output and formatting of those tests. This makes the tests not only more realistic, but also less sensitive to otherwise-irrelevant implementation details (such as the names and signatures of unexported types and functions in the testing package). Fixes #61016. Change-Id: I646fbbd7cfeb00382054677f726c05fc9d35d0dc Reviewed-on: https://go-review.googlesource.com/c/go/+/506955 Auto-Submit: Bryan Mills <bcmills@google.com> Reviewed-by: Alan Donovan <adonovan@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
125 lines
2.4 KiB
Go
125 lines
2.4 KiB
Go
// Copyright 2017 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package testing_test
|
|
|
|
import (
|
|
"sync"
|
|
"testing"
|
|
)
|
|
|
|
// The line numbering of this file is important for TestTBHelper.
|
|
|
|
func notHelper(t *testing.T, msg string) {
|
|
t.Error(msg)
|
|
}
|
|
|
|
func helper(t *testing.T, msg string) {
|
|
t.Helper()
|
|
t.Error(msg)
|
|
}
|
|
|
|
func notHelperCallingHelper(t *testing.T, msg string) {
|
|
helper(t, msg)
|
|
}
|
|
|
|
func helperCallingHelper(t *testing.T, msg string) {
|
|
t.Helper()
|
|
helper(t, msg)
|
|
}
|
|
|
|
func genericHelper[G any](t *testing.T, msg string) {
|
|
t.Helper()
|
|
t.Error(msg)
|
|
}
|
|
|
|
var genericIntHelper = genericHelper[int]
|
|
|
|
func testTestHelper(t *testing.T) {
|
|
testHelper(t)
|
|
}
|
|
|
|
func testHelper(t *testing.T) {
|
|
// Check combinations of directly and indirectly
|
|
// calling helper functions.
|
|
notHelper(t, "0")
|
|
helper(t, "1")
|
|
notHelperCallingHelper(t, "2")
|
|
helperCallingHelper(t, "3")
|
|
|
|
// Check a function literal closing over t that uses Helper.
|
|
fn := func(msg string) {
|
|
t.Helper()
|
|
t.Error(msg)
|
|
}
|
|
fn("4")
|
|
|
|
t.Run("sub", func(t *testing.T) {
|
|
helper(t, "5")
|
|
notHelperCallingHelper(t, "6")
|
|
// Check that calling Helper from inside a subtest entry function
|
|
// works as if it were in an ordinary function call.
|
|
t.Helper()
|
|
t.Error("7")
|
|
})
|
|
|
|
// Check that right caller is reported for func passed to Cleanup when
|
|
// multiple cleanup functions have been registered.
|
|
t.Cleanup(func() {
|
|
t.Helper()
|
|
t.Error("10")
|
|
})
|
|
t.Cleanup(func() {
|
|
t.Helper()
|
|
t.Error("9")
|
|
})
|
|
|
|
// Check that helper-ness propagates up through subtests
|
|
// to helpers above. See https://golang.org/issue/44887.
|
|
helperSubCallingHelper(t, "11")
|
|
|
|
// Check that helper-ness propagates up through panic/recover.
|
|
// See https://golang.org/issue/31154.
|
|
recoverHelper(t, "12")
|
|
|
|
genericHelper[float64](t, "GenericFloat64")
|
|
genericIntHelper(t, "GenericInt")
|
|
}
|
|
|
|
func parallelTestHelper(t *testing.T) {
|
|
var wg sync.WaitGroup
|
|
for i := 0; i < 5; i++ {
|
|
wg.Add(1)
|
|
go func() {
|
|
notHelperCallingHelper(t, "parallel")
|
|
wg.Done()
|
|
}()
|
|
}
|
|
wg.Wait()
|
|
}
|
|
|
|
func helperSubCallingHelper(t *testing.T, msg string) {
|
|
t.Helper()
|
|
t.Run("sub2", func(t *testing.T) {
|
|
t.Helper()
|
|
t.Fatal(msg)
|
|
})
|
|
}
|
|
|
|
func recoverHelper(t *testing.T, msg string) {
|
|
t.Helper()
|
|
defer func() {
|
|
t.Helper()
|
|
if err := recover(); err != nil {
|
|
t.Errorf("recover %s", err)
|
|
}
|
|
}()
|
|
doPanic(t, msg)
|
|
}
|
|
|
|
func doPanic(t *testing.T, msg string) {
|
|
t.Helper()
|
|
panic(msg)
|
|
}
|