mirror of
https://github.com/golang/go.git
synced 2025-05-05 23:53:05 +00:00
5eefd052ad
This commit adds support for calling rename from the gopls command line, e.g. $ gopls rename -w ~/tmp/foo/main.go:8:6 $ gopls rename -w ~/tmp/foo/main.go:#53 Optional arguments are: - -w, which writes the changes back to the original file; and - -d, which prints a unified diff to stdout With no arguments, the changed files are printed to stdout. It: - adds internal/lsp/cmd/rename.go, which implements the command; - adds "rename" to the list of commands in internal/lsp/cmd/cmd.go; - removes the dummy test from internal/lsp/cmd/cmd_test.go; and - adds internal/lsp/cmd/rename_test.go, which uses the existing "golden" data to implement its tests. Updates #32875 Change-Id: I5cab5a40b4aa26357b26b0caf4ed54dbd2284d0f GitHub-Last-Rev: fe853d325ef91f8f911987790fcba7a5a777b6ce GitHub-Pull-Request: golang/tools#157 Reviewed-on: https://go-review.googlesource.com/c/tools/+/194878 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Cottrell <iancottrell@google.com>
67 lines
1.7 KiB
Go
67 lines
1.7 KiB
Go
// Copyright 2019 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package cmd_test
|
|
|
|
import (
|
|
"fmt"
|
|
"sort"
|
|
"strings"
|
|
"testing"
|
|
|
|
"golang.org/x/tools/internal/lsp/cmd"
|
|
"golang.org/x/tools/internal/lsp/tests"
|
|
"golang.org/x/tools/internal/span"
|
|
"golang.org/x/tools/internal/tool"
|
|
)
|
|
|
|
var renameModes = [][]string{
|
|
[]string{},
|
|
[]string{"-d"},
|
|
}
|
|
|
|
func (r *runner) Rename(t *testing.T, data tests.Renames) {
|
|
sortedSpans := sortSpans(data) // run the tests in a repeatable order
|
|
for _, spn := range sortedSpans {
|
|
tag := data[spn]
|
|
filename := spn.URI().Filename()
|
|
for _, mode := range renameModes {
|
|
goldenTag := data[spn] + strings.Join(mode, "") + "-rename"
|
|
expect := string(r.data.Golden(goldenTag, filename, func() ([]byte, error) {
|
|
return []byte{}, nil
|
|
}))
|
|
|
|
app := cmd.New("gopls-test", r.data.Config.Dir, r.data.Config.Env)
|
|
loc := fmt.Sprintf("%v", spn)
|
|
args := []string{"-remote=internal", "rename"}
|
|
if strings.Join(mode, "") != "" {
|
|
args = append(args, strings.Join(mode, ""))
|
|
}
|
|
args = append(args, loc, tag)
|
|
var err error
|
|
got := captureStdOut(t, func() {
|
|
err = tool.Run(r.ctx, app, args)
|
|
})
|
|
if err != nil {
|
|
got = err.Error()
|
|
}
|
|
got = normalizePaths(r.data, got)
|
|
if expect != got {
|
|
t.Errorf("rename failed with %#v expected:\n%s\ngot:\n%s", args, expect, got)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
func sortSpans(data map[span.Span]string) []span.Span {
|
|
spans := make([]span.Span, 0, len(data))
|
|
for spn, _ := range data {
|
|
spans = append(spans, spn)
|
|
}
|
|
sort.Slice(spans, func(i, j int) bool {
|
|
return span.Compare(spans[i], spans[j]) < 0
|
|
})
|
|
return spans
|
|
}
|