mirror of
https://github.com/golang/go.git
synced 2025-05-05 23:53:05 +00:00
744a51dd88
This allows us to use the diff.ApplyEdits in tests, saving us from a different implementation. It also prepares for command lines that need to use diff features based on the results of a protocol message. Splitting content into lines is too easy to get wrong, and needs to be done correctly or the diff results make no sense. This adds the SplitLines function to the diff pacakge to do it right and then uses it everwhere we we already doing it wrong. It also makes all the diff tests external black box tests. Change-Id: I698227d5769a2bfbfd22a64ea42906b1df9268d9 Reviewed-on: https://go-review.googlesource.com/c/tools/+/171027 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
102 lines
2.7 KiB
Go
102 lines
2.7 KiB
Go
// Copyright 2018 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package lsp
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"strings"
|
|
|
|
"golang.org/x/tools/internal/lsp/protocol"
|
|
"golang.org/x/tools/internal/lsp/source"
|
|
"golang.org/x/tools/internal/span"
|
|
)
|
|
|
|
func (s *Server) codeAction(ctx context.Context, params *protocol.CodeActionParams) ([]protocol.CodeAction, error) {
|
|
uri := span.NewURI(params.TextDocument.URI)
|
|
view := s.findView(ctx, uri)
|
|
_, m, err := newColumnMap(ctx, view, uri)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
spn, err := m.RangeSpan(params.Range)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
var codeActions []protocol.CodeAction
|
|
// Determine what code actions we should take based on the diagnostics.
|
|
if findImportErrors(params.Context.Diagnostics) {
|
|
codeAction, err := organizeImports(ctx, view, spn)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
if codeAction != nil {
|
|
codeActions = append(codeActions, *codeAction)
|
|
}
|
|
}
|
|
return codeActions, nil
|
|
}
|
|
|
|
// findImports determines if a given diagnostic represents an error that could
|
|
// be fixed by organizing imports.
|
|
// TODO(rstambler): We need a better way to check this than string matching.
|
|
func findImportErrors(diagnostics []protocol.Diagnostic) bool {
|
|
for _, diagnostic := range diagnostics {
|
|
// "undeclared name: X" may be an unresolved import.
|
|
if strings.HasPrefix(diagnostic.Message, "undeclared name: ") {
|
|
return true
|
|
}
|
|
// "could not import: X" may be an invalid import.
|
|
if strings.HasPrefix(diagnostic.Message, "could not import: ") {
|
|
return true
|
|
}
|
|
// "X imported but not used" is an unused import.
|
|
if strings.HasSuffix(diagnostic.Message, " imported but not used") {
|
|
return true
|
|
}
|
|
}
|
|
return false
|
|
}
|
|
|
|
func organizeImports(ctx context.Context, v source.View, s span.Span) (*protocol.CodeAction, error) {
|
|
f, m, err := newColumnMap(ctx, v, s.URI())
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
rng, err := s.Range(m.Converter)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
if rng.Start == rng.End {
|
|
// If we have a single point, assume we want the whole file.
|
|
tok := f.GetToken(ctx)
|
|
if tok == nil {
|
|
return nil, fmt.Errorf("no file information for %s", f.URI())
|
|
}
|
|
rng.End = tok.Pos(tok.Size())
|
|
}
|
|
edits, err := source.Imports(ctx, f, rng)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
protocolEdits, err := ToProtocolEdits(m, edits)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
if len(protocolEdits) == 0 {
|
|
return nil, nil
|
|
}
|
|
codeAction := protocol.CodeAction{
|
|
Title: "Organize Imports",
|
|
Kind: protocol.SourceOrganizeImports,
|
|
Edit: &protocol.WorkspaceEdit{
|
|
Changes: &map[string][]protocol.TextEdit{
|
|
string(s.URI()): protocolEdits,
|
|
},
|
|
},
|
|
}
|
|
return &codeAction, nil
|
|
}
|