mirror of
https://github.com/golang/go.git
synced 2025-05-17 13:24:38 +00:00
deaf29a8a8
CL 261677 fixed a logic issue in walk's alias detection, where it was checking the RHS expression instead of the LHS expression when trying to determine the kind of assignment. However, correcting this exposed a latent issue with assigning to result parameters in functions with defers, where an assignment could become visible earlier than intended if a later expression could panic. Fixes #43835. Change-Id: I061ced125e3896e26d65f45b28c99db2c8a74a8c Reviewed-on: https://go-review.googlesource.com/c/go/+/285633 Run-TryBot: Matthew Dempsky <mdempsky@google.com> Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com> Reviewed-by: Keith Randall <khr@golang.org> Trust: Matthew Dempsky <mdempsky@google.com>
34 lines
456 B
Go
34 lines
456 B
Go
// run
|
|
|
|
// Copyright 2021 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package main
|
|
|
|
func main() {
|
|
if f() {
|
|
panic("FAIL")
|
|
}
|
|
if bad, _ := g(); bad {
|
|
panic("FAIL")
|
|
}
|
|
}
|
|
|
|
func f() (bad bool) {
|
|
defer func() {
|
|
recover()
|
|
}()
|
|
var p *int
|
|
bad, _ = true, *p
|
|
return
|
|
}
|
|
|
|
func g() (bool, int) {
|
|
defer func() {
|
|
recover()
|
|
}()
|
|
var p *int
|
|
return true, *p
|
|
}
|