mirror of
https://github.com/golang/go.git
synced 2025-05-05 15:43:04 +00:00
d1d6d0cbb6
We plan to change goimports to use go/packages, which requires changing its internal design. Having tests use the external interface makes those changes easier. After this change almost all testing is through Process. Broadly speaking, the changes are: - Switch to subtests wherever possible. This involved making up many names, which I hope are accurate. - Convert tests that used findImport directly to use Process instead. This often made them slightly larger but not unduly IMO. - Replace simple tests with entries in the giant table at the top. - Remove uses of custom goroots, which are troublesome for go/packages' use of the go command. Almost none of them were actually necessary. I left one in TestGoRootPrefixOfGoPath; I'm not sure how to handle it yet. Change-Id: I7b810750f72842b58223f102097ccbb51b82bf39 Reviewed-on: https://go-review.googlesource.com/c/140840 Run-TryBot: Heschi Kreinick <heschi@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>