mirror of
https://github.com/golang/go.git
synced 2025-05-17 13:24:38 +00:00
f13cec9f57
See comment 4 of https://code.google.com/p/go/issues/detail?id=8483#c4: "So if a user creates a http.Client, issues a bunch of requests and then wants to shutdown it and all opened connections; what is she intended to do? The report suggests that just waiting for all pending requests and calling CloseIdleConnections won't do, as there can be new racing connections. Obviously she can't do what you've done in the test, as it uses the unexported function. If this happens periodically, it can lead to serious resource leaks (the transport is also preserved alive). Am I missing something?" This CL tracks the user's intention to close all idle connections (CloseIdleConnections sets it true; and making a new request sets it false). If a pending dial finishes and nobody wants it, before it's retained for a future caller, the "wantIdle" bool is checked and it's closed if the user has called CloseIdleConnections without a later call to make a new request. Fixes #8483 LGTM=adg R=golang-codereviews, dvyukov, adg CC=golang-codereviews, rsc https://golang.org/cl/148970043
104 lines
2.2 KiB
Go
104 lines
2.2 KiB
Go
// Copyright 2011 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// Bridge package to expose http internals to tests in the http_test
|
|
// package.
|
|
|
|
package http
|
|
|
|
import (
|
|
"net"
|
|
"time"
|
|
)
|
|
|
|
func NewLoggingConn(baseName string, c net.Conn) net.Conn {
|
|
return newLoggingConn(baseName, c)
|
|
}
|
|
|
|
var ExportAppendTime = appendTime
|
|
|
|
func (t *Transport) NumPendingRequestsForTesting() int {
|
|
t.reqMu.Lock()
|
|
defer t.reqMu.Unlock()
|
|
return len(t.reqCanceler)
|
|
}
|
|
|
|
func (t *Transport) IdleConnKeysForTesting() (keys []string) {
|
|
keys = make([]string, 0)
|
|
t.idleMu.Lock()
|
|
defer t.idleMu.Unlock()
|
|
if t.idleConn == nil {
|
|
return
|
|
}
|
|
for key := range t.idleConn {
|
|
keys = append(keys, key.String())
|
|
}
|
|
return
|
|
}
|
|
|
|
func (t *Transport) IdleConnCountForTesting(cacheKey string) int {
|
|
t.idleMu.Lock()
|
|
defer t.idleMu.Unlock()
|
|
if t.idleConn == nil {
|
|
return 0
|
|
}
|
|
for k, conns := range t.idleConn {
|
|
if k.String() == cacheKey {
|
|
return len(conns)
|
|
}
|
|
}
|
|
return 0
|
|
}
|
|
|
|
func (t *Transport) IdleConnChMapSizeForTesting() int {
|
|
t.idleMu.Lock()
|
|
defer t.idleMu.Unlock()
|
|
return len(t.idleConnCh)
|
|
}
|
|
|
|
func (t *Transport) IsIdleForTesting() bool {
|
|
t.idleMu.Lock()
|
|
defer t.idleMu.Unlock()
|
|
return t.wantIdle
|
|
}
|
|
|
|
func (t *Transport) RequestIdleConnChForTesting() {
|
|
t.getIdleConnCh(connectMethod{nil, "http", "example.com"})
|
|
}
|
|
|
|
func (t *Transport) PutIdleTestConn() bool {
|
|
c, _ := net.Pipe()
|
|
return t.putIdleConn(&persistConn{
|
|
t: t,
|
|
conn: c, // dummy
|
|
closech: make(chan struct{}), // so it can be closed
|
|
cacheKey: connectMethodKey{"", "http", "example.com"},
|
|
})
|
|
}
|
|
|
|
func NewTestTimeoutHandler(handler Handler, ch <-chan time.Time) Handler {
|
|
f := func() <-chan time.Time {
|
|
return ch
|
|
}
|
|
return &timeoutHandler{handler, f, ""}
|
|
}
|
|
|
|
func ResetCachedEnvironment() {
|
|
httpProxyEnv.reset()
|
|
httpsProxyEnv.reset()
|
|
noProxyEnv.reset()
|
|
}
|
|
|
|
var DefaultUserAgent = defaultUserAgent
|
|
|
|
// SetPendingDialHooks sets the hooks that run before and after handling
|
|
// pending dials.
|
|
func SetPendingDialHooks(before, after func()) {
|
|
prePendingDial, postPendingDial = before, after
|
|
}
|
|
|
|
var ExportServerNewConn = (*Server).newConn
|
|
|
|
var ExportCloseWriteAndWait = (*conn).closeWriteAndWait
|