Rebecca Stambler fd6a59f26d internal/lsp/cache: fix race condition in type-checking ...

We had previously been returning the metadata map in a few of the
loading functions. We don't actually need the map; we only need the
actual metadata. The race was caused by the return of the f.meta field
in a few functions, unprotected by the f.mu lock. This was likely a
result of the f.mu lock being added after the fact.

Fixes golang/go#33978

Change-Id: Ice5778d9d6dea23304237baf321b55d4fee6599c
Reviewed-on: https://go-review.googlesource.com/c/tools/+/193717
Reviewed-by: Ian Cottrell <iancottrell@google.com>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

2019-09-05 20:58:25 +00:00

..

cache.go

internal/lsp: remove the non context xlog path

2019-07-15 03:45:47 +00:00

check.go

internal/lsp: avoid using the importer's context as much as possible

2019-09-05 15:54:44 +00:00

external.go

internal/lsp: split the telemetry library out

2019-08-15 21:28:02 +00:00

file.go

internal/lsp: fix deadlock in type-checking

2019-09-05 03:50:54 +00:00

gofile.go

internal/lsp/cache: fix race condition in type-checking

2019-09-05 20:58:25 +00:00

load.go

internal/lsp/cache: fix race condition in type-checking

2019-09-05 20:58:25 +00:00

modfile.go

internal/lsp: use x/xerrors to create new errors

2019-08-06 19:46:56 +00:00

parse.go

internal/lsp: unlabel context, log errors when canceled

2019-08-20 20:39:21 +00:00

pkg.go

go/analysis: handle common nil pointers

2019-08-24 21:01:00 +00:00

session.go

internal/lsp: start handling watched file change events

2019-08-26 19:00:32 +00:00

sumfile.go

internal/lsp: use x/xerrors to create new errors

2019-08-06 19:46:56 +00:00

token.go

internal/lsp: unlabel context, log errors when canceled

2019-08-20 20:39:21 +00:00

view.go

internal/lsp: fix deadlock in type-checking

2019-09-05 03:50:54 +00:00

watcher.go

internal/lsp: fix deadlocks loading lots of files at once

2019-07-03 17:22:52 +00:00