cybercyst/go
1
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-05-05 15:43:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
CodeReviewComments
Russ Cox edited this page 2023-12-14 22:14:45 -05:00
Clone

Wiki Page Revisions

104 Commits

Author SHA1 Message Date
Dmitri Shuralyov
f22d526c92 Revert a change that was added without proper discussion. We can consider re-adding it after further discussion. 2018-09-27 17:43:02 -04:00
radbaron
88a45aeef8 I love this document and want to make it perfect. 2018-08-30 14:04:07 +01:00
Ian Lance Taylor
5a40ba36d3 Added "comprehensive" in "not a style guide" 2018-07-26 16:56:05 -07:00
Kenshi Kamata
f9af9d4123 fix typo 2018-07-20 20:44:39 +09:00
luantao
baec72a245 I think this place is wrong. 2018-07-05 22:45:33 +08:00
Victor van Poppelen
dbdd5b00ee Grammar fix. 2018-05-08 15:42:04 -07:00
Tomoya Ishizaki
2456bc2ce6 Updated CodeReviewComments (markdown) 2018-03-03 10:00:37 +09:00
vkuzmin-uber
e4063d745d improved previous change, better english 2018-02-21 12:34:37 -08:00
vkuzmin-uber
7e850bd28c I recently attempted to formalize this rule and implemented as golint feature https://github.com/golang/lint/issues/374. It was rejected and closed. I have decided at least mention here that this rule is not so obvious. 2018-02-21 12:26:52 -08:00
lylex
4cc16f331b Fix a typo 2018-02-10 22:35:40 +08:00
Emmanuel T Odeke
1f9a3844ff Removed vestiges of code.google.com as requested by @dgryski in https://github.com/golang/go/issues/23678 2018-02-03 01:08:00 -07:00
Brad Fitzpatrick
155654e370 Updated CodeReviewComments (markdown) 2018-01-29 11:35:45 -08:00
Lachlan Cooper
4434a5a7a1 Remove extra word from "Indent Error Flow" example 2017-10-15 18:51:47 +11:00
Hoon H
8898bf281b Add formatting to render code like code. 2017-09-18 12:14:18 +09:00
Brad Fitzpatrick
3c4eb23036 Updated CodeReviewComments (markdown) 2017-07-15 14:17:50 -07:00
Brad Fitzpatrick
d2c439a67d Updated CodeReviewComments (markdown) 2017-07-15 14:17:21 -07:00
Andrew Gerrand
4d5a1b0909 Updated CodeReviewComments (markdown) 2017-02-02 12:06:50 +11:00
Kenny Grant
c9f7de7cf5 Fix crypt-rand link 2017-01-31 13:46:31 +00:00
Jaana B. Dogan
5a81ed6a9b Updated CodeReviewComments (markdown) 2017-01-30 21:58:59 -08:00
Jaana B. Dogan
220c534dad Add Synchronous Functions. 2017-01-30 14:01:00 -08:00
Jaana B. Dogan
7ca7f1f849 Update Receiver Type. 2017-01-30 13:59:18 -08:00
Jaana B. Dogan
1755928e91 Updated CodeReviewComments (markdown) 2017-01-30 11:55:39 -08:00
Jaana B. Dogan
1583ba303a Capitalize gofmt. 2017-01-30 11:52:43 -08:00
Jaana B. Dogan
0df7fa5ffb Update Named Result Parameters. 2017-01-30 11:51:05 -08:00
Jaana B. Dogan
4ac42e3808 Updated CodeReviewComments (markdown) 2017-01-30 11:04:39 -08:00
Jaana B. Dogan
8656afc973 Revise "Package Comments". 2017-01-30 11:03:46 -08:00
Jaana B. Dogan
2840754460 Updated CodeReviewComments (markdown) 2017-01-30 10:55:16 -08:00
Jaana B. Dogan
88f0e01cb0 Add Intefaces. 2017-01-30 10:20:32 -08:00
Jaana B. Dogan
ad8c445b31 Add In-Band Errors. 2017-01-30 10:15:18 -08:00
Jaana B. Dogan
860d784630 Revise Imports. 2017-01-30 10:08:02 -08:00
Jaana B. Dogan
f11f8f779c Updated CodeReviewComments (markdown) 2017-01-30 10:05:50 -08:00
Jaana B. Dogan
8590e71d31 Add Goroutine Lifetimes. 2017-01-30 09:38:59 -08:00
Jaana B. Dogan
b181e78460 Add Examples. 2017-01-30 09:36:22 -08:00
Jaana B. Dogan
9b33933802 Add CryptoRand. 2017-01-30 09:32:22 -08:00
Jaana B. Dogan
dcc731ca52 Add copying. 2017-01-30 09:28:00 -08:00
Jaana B. Dogan
b824d41601 Add contexts. 2017-01-30 09:25:17 -08:00
Steve Carrupt
6a3e308a54 log.Print should be log.Printf("Reading %s: %v", filename, err) because format specifiers and arguments are used 2016-11-24 09:49:46 +09:00
Martin Bertschler
6db1649f56 Code comments for structs or functions should always start with the name of the thing they are documenting. 2016-10-23 23:00:46 +02:00
Terry Liu
0e2fe1970c Missing word fix 2016-10-21 22:20:03 -07:00
Toby Allen
771f1c7c76 slightly better english grammer and makes it easier to understand which is the prefered method 2016-10-14 21:59:05 +01:00
Dmitri Shuralyov
2c403c2aee Update http links to https. It's 2016, no reason not to since golang.org supports it. 2016-09-25 00:07:16 -07:00
Christopher Dunn
4cb9dac38c Fixed typo 2016-07-03 12:24:45 -07:00
Kevin Gillette
68ab16c703 "Some rules of thumb" -> "Some useful guidelines". Whether historically accurate or not, "rule of thumb" is frequently perceived to have abusive origins. 2016-02-19 10:33:35 -07:00
Andrew Gerrand
e6f8213b70 Revert bad edit 2016-02-09 08:26:28 +11:00
Andrew Gerrand
2c6abb8a37 Revert ba29054a63aac679bbfe042387909b5bc94c037e...05b95d71ee086df99c922817e1fa318e73cd7135 on CodeReviewComments 2016-02-09 08:25:13 +11:00
Steve Streeting
05b95d71ee Updated CodeReviewComments (markdown) 2015-07-28 15:05:14 +01:00
Steve Streeting
ba29054a63 Updated CodeReviewComments (markdown) 2015-07-28 15:04:30 +01:00
Earl J. Wagner
e3ee7b02ab Updated CodeReviewComments (markdown) 2015-01-11 15:20:33 -06:00
Earl J. Wagner
2ae2832309 Updated CodeReviewComments (markdown) 2015-01-10 13:55:06 -06:00
Earl J. Wagner
7dda73cc43 Adds "Declaring Empty Slices". 2015-01-05 11:43:49 -06:00