From b955aa571a359a863ff3c2ce99d360947f9dd803 Mon Sep 17 00:00:00 2001 From: Filippo Valsorda <1225294+FiloSottile@users.noreply.github.com> Date: Tue, 5 Nov 2019 16:30:21 -0500 Subject: [PATCH] Fix Import Blank subtitle, see #35319 --- CodeReviewComments.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CodeReviewComments.md b/CodeReviewComments.md index cfe5b9c4..a6d12cba 100644 --- a/CodeReviewComments.md +++ b/CodeReviewComments.md @@ -21,6 +21,7 @@ You can view this as a supplement to [Effective Go](https://golang.org/doc/effec * [Goroutine Lifetimes](#goroutine-lifetimes) * [Handle Errors](#handle-errors) * [Imports](#imports) +* [Import Blank](#import-blank) * [Import Dot](#import-dot) * [In-Band Errors](#in-band-errors) * [Indent Error Flow](#indent-error-flow) @@ -219,7 +220,7 @@ import ( goimports will do this for you. -## ImportBlank +## Import Blank Packages that are imported only for their side effects (using the syntax `import _ "pkg"`) should only be imported in the main package of a program, or in tests